home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 58424403

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/245#issuecomment-58424403 https://api.github.com/repos/pydata/xarray/issues/245 58424403 MDEyOklzc3VlQ29tbWVudDU4NDI0NDAz 1217238 2014-10-08T20:43:49Z 2014-10-08T20:43:49Z MEMBER

Is there a reason you switched to using accessors (e.g., get_variables) instead of properties? Properties feel a little more pythonic to me. I like the idea of making property classes (e.g., DataStoreVariables) that abstract away the set_variable nonsense behind a dictionary like interface. I can submit a patch to add that, if you like.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  44718119
Powered by Datasette · Queries took 0.759ms · About: xarray-datasette