issue_comments

Table actions

7 rows where issue = 445045305 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Add examples for `DataArrayRolling.reduce()` · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
498333901 https://github.com/pydata/xarray/pull/2968#issuecomment-498333901 https://api.github.com/repos/pydata/xarray/issues/2968 MDEyOklzc3VlQ29tbWVudDQ5ODMzMzkwMQ== dcherian 2448579 2019-06-03T16:40:46Z 2019-06-03T16:40:46Z MEMBER

Thanks @kmsquire . The tests failed but they seem unrelated (the docs build passed).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add examples for `DataArrayRolling.reduce()`  445045305
493632403 https://github.com/pydata/xarray/pull/2968#issuecomment-493632403 https://api.github.com/repos/pydata/xarray/issues/2968 MDEyOklzc3VlQ29tbWVudDQ5MzYzMjQwMw== kmsquire 223250 2019-05-18T00:18:37Z 2019-05-18T00:18:37Z CONTRIBUTOR

@dcherian added. Let me know if you want any changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add examples for `DataArrayRolling.reduce()`  445045305
493499465 https://github.com/pydata/xarray/pull/2968#issuecomment-493499465 https://api.github.com/repos/pydata/xarray/issues/2968 MDEyOklzc3VlQ29tbWVudDQ5MzQ5OTQ2NQ== dcherian 2448579 2019-05-17T15:38:59Z 2019-05-17T15:38:59Z MEMBER

@kmsquire thanks. Can you also add some text to https://xarray.pydata.org/en/stable/computation.html#rolling-window-operations (i.e. computation.rst) describing what min_periods does.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add examples for `DataArrayRolling.reduce()`  445045305
493497801 https://github.com/pydata/xarray/pull/2968#issuecomment-493497801 https://api.github.com/repos/pydata/xarray/issues/2968 MDEyOklzc3VlQ29tbWVudDQ5MzQ5NzgwMQ== kmsquire 223250 2019-05-17T15:34:23Z 2019-05-17T15:34:23Z CONTRIBUTOR

Changed to simply add examples to DataArrayRolling.reduce(). I changed the original description accordingly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add examples for `DataArrayRolling.reduce()`  445045305
493494703 https://github.com/pydata/xarray/pull/2968#issuecomment-493494703 https://api.github.com/repos/pydata/xarray/issues/2968 MDEyOklzc3VlQ29tbWVudDQ5MzQ5NDcwMw== kmsquire 223250 2019-05-17T15:25:45Z 2019-05-17T15:26:03Z CONTRIBUTOR

Actually, every window has at least 1 valid value, so this change isn't really needed at all.

I'll remove the code changes, and change the added example to show a working example of what I wanted.

I will say that min_periods isn't the most obvious name for this parameter--I'm struggling to figure out how the number of valid observations in a window is related to periods or periodicity.

Would it be reasonable to deprecate min_periods and change it to something like min_observations?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add examples for `DataArrayRolling.reduce()`  445045305
493489589 https://github.com/pydata/xarray/pull/2968#issuecomment-493489589 https://api.github.com/repos/pydata/xarray/issues/2968 MDEyOklzc3VlQ29tbWVudDQ5MzQ4OTU4OQ== kmsquire 223250 2019-05-17T15:10:49Z 2019-05-17T15:10:49Z CONTRIBUTOR

@mathause, thank you, I didn't realize that. I'll make those changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add examples for `DataArrayRolling.reduce()`  445045305
493453581 https://github.com/pydata/xarray/pull/2968#issuecomment-493453581 https://api.github.com/repos/pydata/xarray/issues/2968 MDEyOklzc3VlQ29tbWVudDQ5MzQ1MzU4MQ== mathause 10194086 2019-05-17T13:28:29Z 2019-05-17T13:28:29Z MEMBER

I think you can keep the function signature of reduce but rather allow to set min_periods=0 in __init__ (This is currently disallowed on Line 77).

Then you change your code in reduce to ``` python if self.min_periods == 0: return result

```

btw: If I understand correctly, this does not need to be added for the other functions ds.rolling(...).mean() calls reduce on Line 238.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add examples for `DataArrayRolling.reduce()`  445045305

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);