issues: 445045305

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
445045305 MDExOlB1bGxSZXF1ZXN0Mjc5NTc4Mzgw 2968 Add examples for `DataArrayRolling.reduce()` 223250 closed 0     7 2019-05-16T16:17:00Z 2019-06-04T14:47:09Z 2019-06-04T14:47:08Z CONTRIBUTOR   0 pydata/xarray/pulls/2968
  • ~~When reducing over a rolling window, DataArrayRolling.reduce() only returns values where the complete rolling window is fully conatined within the base array; the remaining locations where the window overlaps the array border are filled with NaN~~
  • ~~However, in some situations, it is desirable to obtain values from the reducer function for all locations. This commit adds a keyword argument, include_border, to DataArrayRolling.reduce() and DataSetRolling.reduce() to allow this behavior.~~

~~If this seems okay, I have some questions:~~

~~1. Should this behavior be added to specific reducing functions (sum, mean, etc.)? As an alternative, all of the specialized functions for DataArrayRolling have corresponding numpy nan* functions, so support could be added for those. (The current PR is still useful for other reducing functions, which is my use case.)~~ ~~2. I don't use dask, so I don't know if this is needed/desired for the dask versions of these functions.~~

As @mathause pointed out, the functionality desired already exists by passing min_periods=1 to DataArray.rolling(). So this MR has been updated to simply include some examples for DataArrayRolling.reduce()

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2968/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables