issue_comments: 493494703

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2968#issuecomment-493494703 https://api.github.com/repos/pydata/xarray/issues/2968 493494703 MDEyOklzc3VlQ29tbWVudDQ5MzQ5NDcwMw== 223250 2019-05-17T15:25:45Z 2019-05-17T15:26:03Z CONTRIBUTOR

Actually, every window has at least 1 valid value, so this change isn't really needed at all.

I'll remove the code changes, and change the added example to show a working example of what I wanted.

I will say that min_periods isn't the most obvious name for this parameter--I'm struggling to figure out how the number of valid observations in a window is related to periods or periodicity.

Would it be reasonable to deprecate min_periods and change it to something like min_observations?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   445045305