issue_comments

Table actions

6 rows where issue = 438421176 and user = 6213168 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • crusaderky · 6 ✖

issue 1

  • Typing for DataArray/Dataset · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
505148315 https://github.com/pydata/xarray/pull/2929#issuecomment-505148315 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTE0ODMxNQ== crusaderky 6213168 2019-06-24T19:32:36Z 2019-06-24T19:32:36Z MEMBER

Sorry I didn't have time last week - I'll try merging into the pr ASAP. I'm in favour of merging to mainline too

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
502502167 https://github.com/pydata/xarray/pull/2929#issuecomment-502502167 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwMjUwMjE2Nw== crusaderky 6213168 2019-06-17T01:04:17Z 2019-06-17T01:04:17Z MEMBER

@max-sixty you can keep adding type info to all functions in dataset.py. I don't think I'll have time to touch it next week anyway... 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
502465584 https://github.com/pydata/xarray/pull/2929#issuecomment-502465584 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwMjQ2NTU4NA== crusaderky 6213168 2019-06-16T16:15:57Z 2019-06-16T16:15:57Z MEMBER

@max-sixty I merged your branch in and did some tweaks to the OrderedDict's. Now moving to add more typing info to dataset.py...

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
502397112 https://github.com/pydata/xarray/pull/2929#issuecomment-502397112 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwMjM5NzExMg== crusaderky 6213168 2019-06-15T20:27:54Z 2019-06-15T20:27:54Z MEMBER

@max-sixty thanks for the work! I'll go through it ASAP

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
490325901 https://github.com/pydata/xarray/pull/2929#issuecomment-490325901 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDQ5MDMyNTkwMQ== crusaderky 6213168 2019-05-08T02:45:57Z 2019-05-08T02:45:57Z MEMBER

DataArray finished; unit tests (hopefully) successful. Will now move to Dataset. Would appreciate an official, final decision from @shoyer et. al. on Hashable vs. str before I continue - also in light of all the hacks Hashable forced me to go through.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
487671110 https://github.com/pydata/xarray/pull/2929#issuecomment-487671110 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDQ4NzY3MTExMA== crusaderky 6213168 2019-04-29T17:30:26Z 2019-04-29T17:30:26Z MEMBER

One of the many reasons why I'm strongly against generic Hashables instead of strings is that I expect user code all over the world to have string-specific functions and methods applied to variable names and dimensions. e.g. [d for d in arr.dims if d.startswith('foo')] The above will produce an error in mypy, and the user will be forced to either disable the test or verbosely convince mypy with a typing.cast that actually in his project he never uses non-string dims.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);