issues: 438421176
This data as json
| id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 438421176 | MDExOlB1bGxSZXF1ZXN0Mjc0NDU1ODQz | 2929 | Typing for DataArray/Dataset | 6213168 | closed | 0 | 25 | 2019-04-29T17:19:35Z | 2019-06-30T10:08:39Z | 2019-06-25T22:03:40Z | MEMBER | 0 | pydata/xarray/pulls/2929 | Status:
* I'm generally not pleased with the amount of added verbosity. Happy to accept suggestions on how to improve.
* Switching all variable names from str to Hashable. Without proper unit tests however (out of scope) non-string hashables are expected not to work most of the times. My preference would still be to stay limited on str...
* DataArray done.
* Dataset not done (except where it was hindering DataArray).
* mypy passes with the only error @shoyer any early feedback is appreciated |
{
"url": "https://api.github.com/repos/pydata/xarray/issues/2929/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
13221727 | pull |