issue_comments: 487671110

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2929#issuecomment-487671110 https://api.github.com/repos/pydata/xarray/issues/2929 487671110 MDEyOklzc3VlQ29tbWVudDQ4NzY3MTExMA== 6213168 2019-04-29T17:30:26Z 2019-04-29T17:30:26Z MEMBER

One of the many reasons why I'm strongly against generic Hashables instead of strings is that I expect user code all over the world to have string-specific functions and methods applied to variable names and dimensions. e.g. [d for d in arr.dims if d.startswith('foo')] The above will produce an error in mypy, and the user will be forced to either disable the test or verbosely convince mypy with a typing.cast that actually in his project he never uses non-string dims.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   438421176