issue_comments

Table actions

5 rows where issue = 438421176 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • shoyer · 5 ✖

issue 1

  • Typing for DataArray/Dataset · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
505640130 https://github.com/pydata/xarray/pull/2929#issuecomment-505640130 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTY0MDEzMA== shoyer 1217238 2019-06-25T22:03:56Z 2019-06-25T22:03:56Z MEMBER

Thanks @max-sixty and @crusaderky !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
505529733 https://github.com/pydata/xarray/pull/2929#issuecomment-505529733 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTUyOTczMw== shoyer 1217238 2019-06-25T16:52:10Z 2019-06-25T16:52:10Z MEMBER

By the way, I think I can write a script based on pep8speaks that writes/updates GitHub comments from within from Travis or Azure Pipelines. We could use that for surfacing mypy results in pull requests. I will probably give that a try over the next few days....

That would be v cool. I'm kinda surprised something like pep8speaks doesn't do this already tbh...

I was considering adding this into pep8speaks, but I think this fundamentally incompatible with pep8speak's design. It runs a handful of pre-specified linters, without actually installing/running user code. But something like mypy needs to actually have xarray and its dependencies installed to work.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
505522494 https://github.com/pydata/xarray/pull/2929#issuecomment-505522494 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTUyMjQ5NA== shoyer 1217238 2019-06-25T16:32:53Z 2019-06-25T16:32:53Z MEMBER

By the way, I think I can write a script based on pep8speaks that writes/updates GitHub comments from within from Travis or Azure Pipelines. We could use that for surfacing mypy results in pull requests. I will probably give that a try over the next few days....

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
505484234 https://github.com/pydata/xarray/pull/2929#issuecomment-505484234 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTQ4NDIzNA== shoyer 1217238 2019-06-25T14:59:36Z 2019-06-25T14:59:36Z MEMBER

@max-sixty do you want to push those changes to @crusaderky's branch? As a maintainer for xarray, I think you should have push permissions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
490589169 https://github.com/pydata/xarray/pull/2929#issuecomment-490589169 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDQ5MDU4OTE2OQ== shoyer 1217238 2019-05-08T18:02:25Z 2019-05-08T18:02:25Z MEMBER

@crusaderky let's discuss that over in https://github.com/pydata/xarray/issues/2292. For now, I would try to defer making a decision on non-string dimension/variable names, even though that means we will have less informative type annotations.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);