home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 505529733

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2929#issuecomment-505529733 https://api.github.com/repos/pydata/xarray/issues/2929 505529733 MDEyOklzc3VlQ29tbWVudDUwNTUyOTczMw== 1217238 2019-06-25T16:52:10Z 2019-06-25T16:52:10Z MEMBER

By the way, I think I can write a script based on pep8speaks that writes/updates GitHub comments from within from Travis or Azure Pipelines. We could use that for surfacing mypy results in pull requests. I will probably give that a try over the next few days....

That would be v cool. I'm kinda surprised something like pep8speaks doesn't do this already tbh...

I was considering adding this into pep8speaks, but I think this fundamentally incompatible with pep8speak's design. It runs a handful of pre-specified linters, without actually installing/running user code. But something like mypy needs to actually have xarray and its dependencies installed to work.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  438421176
Powered by Datasette · Queries took 1.074ms · About: xarray-datasette