issue_comments

Table actions

2 rows where issue = 437765416 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • dcherian · 2 ✖

issue 1

  • Feature/weighted · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
601210885 https://github.com/pydata/xarray/pull/2922#issuecomment-601210885 https://api.github.com/repos/pydata/xarray/issues/2922 MDEyOklzc3VlQ29tbWVudDYwMTIxMDg4NQ== dcherian 2448579 2020-03-19T14:29:42Z 2020-03-19T14:29:42Z MEMBER

This is going in.

Thanks @mathause. This is a major contribution!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/weighted 437765416
545200082 https://github.com/pydata/xarray/pull/2922#issuecomment-545200082 https://api.github.com/repos/pydata/xarray/issues/2922 MDEyOklzc3VlQ29tbWVudDU0NTIwMDA4Mg== dcherian 2448579 2019-10-22T23:35:52Z 2019-10-22T23:35:52Z MEMBER

I decided to replace all NaN in the weights with 0.

Can we raise an error instead? It should be easy for the user to do weights.fillna(0) instead of relying on xarray's magical behaviour.

if weights sum to 0 it returns NaN (and not inf)

Should we raise an error here?

The following returns NaN (could be 1)

I think NaN is fine since that's the result of 1 + 0*np.nan

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/weighted 437765416

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);