issue_comments

Table actions

5 rows where issue = 407523050 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 3

issue 1

  • Fix name loss when masking · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
462419899 https://github.com/pydata/xarray/pull/2749#issuecomment-462419899 https://api.github.com/repos/pydata/xarray/issues/2749 MDEyOklzc3VlQ29tbWVudDQ2MjQxOTg5OQ== shoyer 1217238 2019-02-11T17:35:07Z 2019-02-11T17:35:07Z MEMBER

thanks Yohai!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix name loss when masking 407523050
462342581 https://github.com/pydata/xarray/pull/2749#issuecomment-462342581 https://api.github.com/repos/pydata/xarray/issues/2749 MDEyOklzc3VlQ29tbWVudDQ2MjM0MjU4MQ== yohai 6164157 2019-02-11T14:17:04Z 2019-02-11T14:17:04Z CONTRIBUTOR

@shoyer your fix works. I think it's ready to merge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix name loss when masking 407523050
461271787 https://github.com/pydata/xarray/pull/2749#issuecomment-461271787 https://api.github.com/repos/pydata/xarray/issues/2749 MDEyOklzc3VlQ29tbWVudDQ2MTI3MTc4Nw== pep8speaks 24736507 2019-02-07T02:59:48Z 2019-02-11T14:16:13Z NONE

Hello @yohai! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated on February 11, 2019 at 14:16 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix name loss when masking 407523050
461542452 https://github.com/pydata/xarray/pull/2749#issuecomment-461542452 https://api.github.com/repos/pydata/xarray/issues/2749 MDEyOklzc3VlQ29tbWVudDQ2MTU0MjQ1Mg== yohai 6164157 2019-02-07T18:27:41Z 2019-02-07T18:27:41Z CONTRIBUTOR

I agree that my solution is a bit hacky, but from a computational cost viewpoint they are identical (or almost. I don't think there's a way to avoid one if statement per call of where). I thought my solution is good because catching this at a high level captures all possible edge cases that we might miss at lower ones. But I can try to do what you suggested to.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix name loss when masking 407523050
461538356 https://github.com/pydata/xarray/pull/2749#issuecomment-461538356 https://api.github.com/repos/pydata/xarray/issues/2749 MDEyOklzc3VlQ29tbWVudDQ2MTUzODM1Ng== shoyer 1217238 2019-02-07T18:16:03Z 2019-02-07T18:16:03Z MEMBER

This looks fine, though I'd rather fix this at a lower level, if possible.

This line in computation.py sets the name on result DataArray objects: https://github.com/pydata/xarray/blob/0dfc0e63650deb3da1fb1cba48cda88a704c2d60/xarray/core/computation.py#L210

If keep_attrs=True (you'll need to thread the argument into apply_dataarray_ufunc from apply_ufunc), then we should just copy the name from the first argument instead, e.g., name = args[0].name if keep_attrs else result_name(args).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix name loss when masking 407523050

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);