home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 461538356

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2749#issuecomment-461538356 https://api.github.com/repos/pydata/xarray/issues/2749 461538356 MDEyOklzc3VlQ29tbWVudDQ2MTUzODM1Ng== 1217238 2019-02-07T18:16:03Z 2019-02-07T18:16:03Z MEMBER

This looks fine, though I'd rather fix this at a lower level, if possible.

This line in computation.py sets the name on result DataArray objects: https://github.com/pydata/xarray/blob/0dfc0e63650deb3da1fb1cba48cda88a704c2d60/xarray/core/computation.py#L210

If keep_attrs=True (you'll need to thread the argument into apply_dataarray_ufunc from apply_ufunc), then we should just copy the name from the first argument instead, e.g., name = args[0].name if keep_attrs else result_name(args).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  407523050
Powered by Datasette · Queries took 0.952ms · About: xarray-datasette