issues: 407523050

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
407523050 MDExOlB1bGxSZXF1ZXN0MjUwOTc4NzU1 2749 Fix name loss when masking 6164157 closed 0     5 2019-02-07T02:59:45Z 2019-02-12T01:46:51Z 2019-02-11T17:35:03Z CONTRIBUTOR   0 pydata/xarray/pulls/2749
  • [x] Closes #2457 #2748
  • [x] Tests added
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

I took a simple-minded strategy to fix: just mask and then rename the result to self.name. This is a slight overkill since the renaming will be done on every masking, not just on the edge cases when it's needed, but this is really a very small computational cost and it's much easier and bulletproof.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2749/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables