issue_comments

Table actions

14 rows where issue = 398468139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • fix datetime_to_numeric and Variable._to_numeric · 14 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
462303166 https://github.com/pydata/xarray/pull/2668#issuecomment-462303166 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ2MjMwMzE2Ng== spencerkclark 6628425 2019-02-11T11:58:22Z 2019-02-11T11:58:22Z MEMBER

Thanks for wrapping this up @fujiisoup!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
462268111 https://github.com/pydata/xarray/pull/2668#issuecomment-462268111 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ2MjI2ODExMQ== fujiisoup 6815844 2019-02-11T09:47:24Z 2019-02-11T09:47:24Z MEMBER

Thanks @spencerkclark for reviewing. Merged.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
453817116 https://github.com/pydata/xarray/pull/2668#issuecomment-453817116 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ1MzgxNzExNg== pep8speaks 24736507 2019-01-13T10:09:26Z 2019-02-10T15:04:08Z NONE

Hello @fujiisoup! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated on February 10, 2019 at 15:04 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
462134943 https://github.com/pydata/xarray/pull/2668#issuecomment-462134943 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ2MjEzNDk0Mw== spencerkclark 6628425 2019-02-10T13:55:55Z 2019-02-10T13:55:55Z MEMBER

As I'm not a heavy user of datetime arrays, I personally do not mind if we do not have dask compatibility for datetime_to_numeric.

No worries @fujiisoup, this is totally fine with me. I think the most common use case for datetime arrays is in indexes, which currently need to be stored in memory anyway, so I don't think the dask use case would come up very often.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
462134112 https://github.com/pydata/xarray/pull/2668#issuecomment-462134112 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ2MjEzNDExMg== fujiisoup 6815844 2019-02-10T13:44:54Z 2019-02-10T13:44:54Z MEMBER

@spencerkclark

Sorry for leaving it for a long time. I was a little stressed these days...

Should we strive to have compatibility in datetime_to_numeric there?

As I'm not a heavy user of datetime arrays, I personally do not mind if we do not have dask compatibility for datetime_to_numeric. Probably it would be OK to leave it for the later development if someone wants this feature.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
454017544 https://github.com/pydata/xarray/pull/2668#issuecomment-454017544 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ1NDAxNzU0NA== fujiisoup 6815844 2019-01-14T14:11:28Z 2019-01-14T14:11:28Z MEMBER

Thanks, @spencerkclark, for the PR. It was super helpful.

I will finish it up tonight (hopefully).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
453874778 https://github.com/pydata/xarray/pull/2668#issuecomment-453874778 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ1Mzg3NDc3OA== spencerkclark 6628425 2019-01-13T23:14:00Z 2019-01-13T23:14:00Z MEMBER

It looks I need more work for this (probably a week). It is not working for cftime stuffs, but I do not yet understand how it is handled in xarray.

Thanks @fujiisoup, no worries. There was only one place where I saw a potential issue for cftime dates, which I noted above. I made a PR to your branch with the fix (https://github.com/fujiisoup/xarray/pull/9); let me know if there were other places with issues and I can sort those out too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
453867656 https://github.com/pydata/xarray/pull/2668#issuecomment-453867656 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ1Mzg2NzY1Ng== fujiisoup 6815844 2019-01-13T21:35:07Z 2019-01-13T21:35:07Z MEMBER

Thanks, @spencerkclark

It looks I need more work for this (probably a week). It is not working for cftime stuffs, but I do not yet understand how it is handled in xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
453843848 https://github.com/pydata/xarray/pull/2668#issuecomment-453843848 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ1Mzg0Mzg0OA== shoyer 1217238 2019-01-13T16:29:44Z 2019-01-13T16:29:44Z MEMBER

I couldn't make datetime_to_numeric compatible both np.ndarray and Variable. I think it would be cleaner if Variable has a (private) method to do this, like Variable._to_numeric(offset=None, datetime_unit=None).

Sounds good to me. It's definitely best to handle numpy arrays and xarray.Variable objects separately.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
453832982 https://github.com/pydata/xarray/pull/2668#issuecomment-453832982 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ1MzgzMjk4Mg== fujiisoup 6815844 2019-01-13T14:10:32Z 2019-01-13T14:10:32Z MEMBER

I couldn't make datetime_to_numeric compatible both np.ndarray and Variable. I think it would be cleaner if Variable has a (private) method to do this, like Variable._to_numeric(offset=None, datetime_unit=None).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
453680857 https://github.com/pydata/xarray/pull/2668#issuecomment-453680857 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ1MzY4MDg1Nw== shoyer 1217238 2019-01-11T22:44:32Z 2019-01-11T22:44:32Z MEMBER

(at least for now, until we can figure out how to handle missing values)

On Fri, Jan 11, 2019 at 2:44 PM Stephan Hoyer shoyer@gmail.com wrote:

OK, in that case let's only worry about NaT for datetime64/timedelta64 arrays.

On Fri, Jan 11, 2019 at 2:37 PM Spencer Clark notifications@github.com wrote:

what convention do you use for missing values in cftime arrays?

Currently there is nothing built in to xarray to support missing values for cftime arrays. I think we would have to come up with a convention.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2668#issuecomment-453679270, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1iSjXGAEXm6e5gqGCY390bNdMIiMks5vCRISgaJpZM4Z8P5F .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
453680807 https://github.com/pydata/xarray/pull/2668#issuecomment-453680807 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ1MzY4MDgwNw== shoyer 1217238 2019-01-11T22:44:18Z 2019-01-11T22:44:18Z MEMBER

OK, in that case let's only worry about NaT for datetime64/timedelta64 arrays.

On Fri, Jan 11, 2019 at 2:37 PM Spencer Clark notifications@github.com wrote:

what convention do you use for missing values in cftime arrays?

Currently there is nothing built in to xarray to support missing values for cftime arrays. I think we would have to come up with a convention.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2668#issuecomment-453679270, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1iSjXGAEXm6e5gqGCY390bNdMIiMks5vCRISgaJpZM4Z8P5F . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
453679270 https://github.com/pydata/xarray/pull/2668#issuecomment-453679270 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ1MzY3OTI3MA== spencerkclark 6628425 2019-01-11T22:37:06Z 2019-01-11T22:37:06Z MEMBER

what convention do you use for missing values in cftime arrays?

Currently there is nothing built in to xarray to support missing values for cftime arrays. I think we would have to come up with a convention.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
453675862 https://github.com/pydata/xarray/pull/2668#issuecomment-453675862 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ1MzY3NTg2Mg== shoyer 1217238 2019-01-11T22:21:45Z 2019-01-11T22:21:45Z MEMBER

@spencerkclark what convention do you use for missing values in cftime arrays?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);