issue_comments: 453874778

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2668#issuecomment-453874778 https://api.github.com/repos/pydata/xarray/issues/2668 453874778 MDEyOklzc3VlQ29tbWVudDQ1Mzg3NDc3OA== 6628425 2019-01-13T23:14:00Z 2019-01-13T23:14:00Z MEMBER

It looks I need more work for this (probably a week). It is not working for cftime stuffs, but I do not yet understand how it is handled in xarray.

Thanks @fujiisoup, no worries. There was only one place where I saw a potential issue for cftime dates, which I noted above. I made a PR to your branch with the fix (https://github.com/fujiisoup/xarray/pull/9); let me know if there were other places with issues and I can sort those out too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   398468139