issue_comments: 453843848

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2668#issuecomment-453843848 https://api.github.com/repos/pydata/xarray/issues/2668 453843848 MDEyOklzc3VlQ29tbWVudDQ1Mzg0Mzg0OA== 1217238 2019-01-13T16:29:44Z 2019-01-13T16:29:44Z MEMBER

I couldn't make datetime_to_numeric compatible both np.ndarray and Variable. I think it would be cleaner if Variable has a (private) method to do this, like Variable._to_numeric(offset=None, datetime_unit=None).

Sounds good to me. It's definitely best to handle numpy arrays and xarray.Variable objects separately.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   398468139