issue_comments

Table actions

7 rows where issue = 282339218 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • dcherian · 7 ✖

issue 1

  • plot.line(): Draw multiple lines for 2D DataArrays. · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
354612770 https://github.com/pydata/xarray/pull/1785#issuecomment-354612770 https://api.github.com/repos/pydata/xarray/issues/1785 MDEyOklzc3VlQ29tbWVudDM1NDYxMjc3MA== dcherian 2448579 2017-12-31T16:26:29Z 2017-12-31T16:26:29Z MEMBER

@shoyer Used your suggested change.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot.line(): Draw multiple lines for 2D DataArrays. 282339218
352918289 https://github.com/pydata/xarray/pull/1785#issuecomment-352918289 https://api.github.com/repos/pydata/xarray/issues/1785 MDEyOklzc3VlQ29tbWVudDM1MjkxODI4OQ== dcherian 2448579 2017-12-19T23:29:25Z 2017-12-19T23:29:25Z MEMBER

@shoyer , @fmaussion : Updated to require either x or hue kwarg if input is 2D.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot.line(): Draw multiple lines for 2D DataArrays. 282339218
352619693 https://github.com/pydata/xarray/pull/1785#issuecomment-352619693 https://api.github.com/repos/pydata/xarray/issues/1785 MDEyOklzc3VlQ29tbWVudDM1MjYxOTY5Mw== dcherian 2448579 2017-12-19T02:20:42Z 2017-12-19T02:20:42Z MEMBER

I've added support for a hue kwarg in the latest commit. Let me know what you think.

I am very nervous about automated heuristics for choosing behavior. I would much rather we raise an error message in cases like this, rather than guessing. (The problem is that heuristics can make it very hard to predict/understand how code will work without trying it.)

Well, this behaviour is analogous to automatically choosing x,y in _plot2d. xarray is already pretty opinionated in this respect.

The current behaviour for a 10000x3 array is to plot 10000 lines which is bad. I'm OK with adding an error message but strongly feel that choosing to plot 3 lines (i.e. always smallest number of lines) is a good default.

Re:error, would that be a message stating that either x or hue be specified if the input is 2D?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot.line(): Draw multiple lines for 2D DataArrays. 282339218
352616868 https://github.com/pydata/xarray/pull/1785#issuecomment-352616868 https://api.github.com/repos/pydata/xarray/issues/1785 MDEyOklzc3VlQ29tbWVudDM1MjYxNjg2OA== dcherian 2448579 2017-12-19T02:02:10Z 2017-12-19T02:02:10Z MEMBER

@shoyer hue sounds perfect. I'll work on adding that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot.line(): Draw multiple lines for 2D DataArrays. 282339218
352616597 https://github.com/pydata/xarray/pull/1785#issuecomment-352616597 https://api.github.com/repos/pydata/xarray/issues/1785 MDEyOklzc3VlQ29tbWVudDM1MjYxNjU5Nw== dcherian 2448579 2017-12-19T02:00:31Z 2017-12-19T02:00:31Z MEMBER

@fmaussion I've added one more commit. If x kwarg is not provided, we automatically choose the longer dimension. So if you have a 10000x3 DataArray, this will plot 3 lines instead of 10000.

Extended an existing test

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot.line(): Draw multiple lines for 2D DataArrays. 282339218
352203031 https://github.com/pydata/xarray/pull/1785#issuecomment-352203031 https://api.github.com/repos/pydata/xarray/issues/1785 MDEyOklzc3VlQ29tbWVudDM1MjIwMzAzMQ== dcherian 2448579 2017-12-16T18:48:02Z 2017-12-16T18:48:02Z MEMBER

@fmaussion I've added more tests. Let me know if you'd like more changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot.line(): Draw multiple lines for 2D DataArrays. 282339218
352097776 https://github.com/pydata/xarray/pull/1785#issuecomment-352097776 https://api.github.com/repos/pydata/xarray/issues/1785 MDEyOklzc3VlQ29tbWVudDM1MjA5Nzc3Ng== dcherian 2448579 2017-12-15T19:58:11Z 2017-12-15T19:58:11Z MEMBER

Now adds a legend too. Can be turned off with add_legend=False

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot.line(): Draw multiple lines for 2D DataArrays. 282339218

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);