issue_comments: 352619693

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1785#issuecomment-352619693 https://api.github.com/repos/pydata/xarray/issues/1785 352619693 MDEyOklzc3VlQ29tbWVudDM1MjYxOTY5Mw== 2448579 2017-12-19T02:20:42Z 2017-12-19T02:20:42Z MEMBER

I've added support for a hue kwarg in the latest commit. Let me know what you think.

I am very nervous about automated heuristics for choosing behavior. I would much rather we raise an error message in cases like this, rather than guessing. (The problem is that heuristics can make it very hard to predict/understand how code will work without trying it.)

Well, this behaviour is analogous to automatically choosing x,y in _plot2d. xarray is already pretty opinionated in this respect.

The current behaviour for a 10000x3 array is to plot 10000 lines which is bad. I'm OK with adding an error message but strongly feel that choosing to plot 3 lines (i.e. always smallest number of lines) is a good default.

Re:error, would that be a message stating that either x or hue be specified if the input is 2D?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   282339218