issue_comments

Table actions

4 rows where issue = 268264252 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 4 ✖

issue 1

  • fixes for warnings related to unit tests and nan comparisons · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
340282693 https://github.com/pydata/xarray/pull/1657#issuecomment-340282693 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDM0MDI4MjY5Mw== shoyer 1217238 2017-10-29T18:19:44Z 2017-10-29T18:19:44Z MEMBER

Everything passed after the pandas 0.21 fixes in #1669

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252
340125292 https://github.com/pydata/xarray/pull/1657#issuecomment-340125292 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDM0MDEyNTI5Mg== shoyer 1217238 2017-10-28T00:18:35Z 2017-10-28T00:18:35Z MEMBER

This looks good to me. Can you add a note to "what's new" (under bug fixes) about removing the warning when comparing with NaN?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252
340121436 https://github.com/pydata/xarray/pull/1657#issuecomment-340121436 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDM0MDEyMTQzNg== shoyer 1217238 2017-10-27T23:37:13Z 2017-10-27T23:37:13Z MEMBER

@jhamman sorry, looks like you'll need to merge in master, too -- I just put in some conflicting changes with my unicode to netCDF3 PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252
340066142 https://github.com/pydata/xarray/pull/1657#issuecomment-340066142 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDM0MDA2NjE0Mg== shoyer 1217238 2017-10-27T19:37:31Z 2017-10-27T19:37:31Z MEMBER

I'm wondering if we should attack #1652 in stages

Yes, absolutely. Let's do it in stages.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);