issues: 268264252

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
268264252 MDExOlB1bGxSZXF1ZXN0MTQ4NTY4Nzc0 1657 fixes for warnings related to unit tests and nan comparisons 2443309 closed 0     9 2017-10-25T04:38:09Z 2017-10-29T18:19:44Z 2017-10-29T18:19:06Z MEMBER   0 pydata/xarray/pulls/1657
  • [x] Closes #1652
  • [x] Tests added / passed
  • [x] Passes git diff upstream/master | flake8 --diff
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

This first commit just includes the fixes for the warnings issued in our unit tests. I've temporarily added -W error to the travis builds so we can see the warnings/errors for all environments. Next step is to address the warnings in the xarray code itself. 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1657/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables