issue_comments

Table actions

9 rows where issue = 268264252 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • fixes for warnings related to unit tests and nan comparisons · 9 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
340282693 https://github.com/pydata/xarray/pull/1657#issuecomment-340282693 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDM0MDI4MjY5Mw== shoyer 1217238 2017-10-29T18:19:44Z 2017-10-29T18:19:44Z MEMBER

Everything passed after the pandas 0.21 fixes in #1669

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252
340240917 https://github.com/pydata/xarray/pull/1657#issuecomment-340240917 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDM0MDI0MDkxNw== jhamman 2443309 2017-10-29T06:33:08Z 2017-10-29T06:33:08Z MEMBER

@shoyer - I think this is all good now. We seem to have acquired another unrelated build failures though...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252
340125292 https://github.com/pydata/xarray/pull/1657#issuecomment-340125292 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDM0MDEyNTI5Mg== shoyer 1217238 2017-10-28T00:18:35Z 2017-10-28T00:18:35Z MEMBER

This looks good to me. Can you add a note to "what's new" (under bug fixes) about removing the warning when comparing with NaN?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252
340122183 https://github.com/pydata/xarray/pull/1657#issuecomment-340122183 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDM0MDEyMjE4Mw== jhamman 2443309 2017-10-27T23:44:37Z 2017-10-27T23:44:37Z MEMBER

@shoyer - updated. If all the tests pass, I'll merge tonight. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252
340121436 https://github.com/pydata/xarray/pull/1657#issuecomment-340121436 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDM0MDEyMTQzNg== shoyer 1217238 2017-10-27T23:37:13Z 2017-10-27T23:37:13Z MEMBER

@jhamman sorry, looks like you'll need to merge in master, too -- I just put in some conflicting changes with my unicode to netCDF3 PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252
340067233 https://github.com/pydata/xarray/pull/1657#issuecomment-340067233 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDM0MDA2NzIzMw== jhamman 2443309 2017-10-27T19:42:33Z 2017-10-27T19:42:33Z MEMBER

Okay, so this knocks off the lowest hanging fruit. I'll pull the pytest error out of the travis build and we'll move forward with this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252
340066142 https://github.com/pydata/xarray/pull/1657#issuecomment-340066142 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDM0MDA2NjE0Mg== shoyer 1217238 2017-10-27T19:37:31Z 2017-10-27T19:37:31Z MEMBER

I'm wondering if we should attack #1652 in stages

Yes, absolutely. Let's do it in stages.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252
340064856 https://github.com/pydata/xarray/pull/1657#issuecomment-340064856 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDM0MDA2NDg1Ng== jhamman 2443309 2017-10-27T19:31:43Z 2017-10-27T19:31:43Z MEMBER

@shoyer - I'm wondering if we should attack #1652 in stages. The remaining warnings are going to take a bit more effort and this first block included a lot of line changes. I'm a bit concerned that if we let this sit, we will end up with a million merge conflicts.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252
339224835 https://github.com/pydata/xarray/pull/1657#issuecomment-339224835 https://api.github.com/repos/pydata/xarray/issues/1657 MDEyOklzc3VlQ29tbWVudDMzOTIyNDgzNQ== jhamman 2443309 2017-10-25T06:08:57Z 2017-10-25T06:08:57Z MEMBER

Down to 96 (was 372) warnings in my py36 test environment.

Two changes that I could uses some input on:

1 - Numpy element wise comparison

```Python def assertEqual(self, a1, a2):

  assert a1 == a2 or (a1 != a1 and a2 != a2)

E DeprecationWarning: elementwise == comparison failed; this will raise an error in the future. ```

@shoyer - you and I put together the assertEqual method a while back. Do we need to check the size of arrays before comparing the values?

2 - Numpy invalid value comparison

e.g.: Python RuntimeWarning: invalid value encountered in greater_equal

I'm hoping there is a succinct way of wrapping many of our nan comparing functions in numpy.errstat. Thoughts here? I've run out of time for tonight but will pick this up again tomorrow.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fixes for warnings related to unit tests and nan comparisons 268264252

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);