issue_comments: 339224835

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1657#issuecomment-339224835 https://api.github.com/repos/pydata/xarray/issues/1657 339224835 MDEyOklzc3VlQ29tbWVudDMzOTIyNDgzNQ== 2443309 2017-10-25T06:08:57Z 2017-10-25T06:08:57Z MEMBER

Down to 96 (was 372) warnings in my py36 test environment.

Two changes that I could uses some input on:

1 - Numpy element wise comparison

```Python def assertEqual(self, a1, a2):

  assert a1 == a2 or (a1 != a1 and a2 != a2)

E DeprecationWarning: elementwise == comparison failed; this will raise an error in the future. ```

@shoyer - you and I put together the assertEqual method a while back. Do we need to check the size of arrays before comparing the values?

2 - Numpy invalid value comparison

e.g.: Python RuntimeWarning: invalid value encountered in greater_equal

I'm hoping there is a succinct way of wrapping many of our nan comparing functions in numpy.errstat. Thoughts here? I've run out of time for tonight but will pick this up again tomorrow.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   268264252