issue_comments
39 rows where issue = 264747372 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: reactions, created_at (date), updated_at (date)
issue 1
- html repr of xarray object (for the notebook) · 39 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
546008898 | https://github.com/pydata/xarray/issues/1627#issuecomment-546008898 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDU0NjAwODg5OA== | rabernat 1197350 | 2019-10-24T16:56:15Z | 2019-10-24T16:56:15Z | MEMBER | 🎉 🍰 🍾 🏆 🏅 |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
507046745 | https://github.com/pydata/xarray/issues/1627#issuecomment-507046745 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDUwNzA0Njc0NQ== | mrocklin 306380 | 2019-06-30T15:49:08Z | 2019-06-30T15:49:08Z | MEMBER | Thought I'd bump this (hopefully no one minds). I think that this is great! |
{ "total_count": 5, "+1": 5, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
405144409 | https://github.com/pydata/xarray/issues/1627#issuecomment-405144409 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDQwNTE0NDQwOQ== | jhamman 2443309 | 2018-07-16T03:59:32Z | 2018-07-16T03:59:32Z | MEMBER |
Agreed. I think that is something we can work on over time. A jupyterlab extension would be cool too but, as you say, it would have a smaller footprint in the shor-term. Also, yeah, Scipy was great. I think I'll go back. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
405014221 | https://github.com/pydata/xarray/issues/1627#issuecomment-405014221 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDQwNTAxNDIyMQ== | benbovy 4160723 | 2018-07-14T10:25:24Z | 2018-07-14T10:25:24Z | MEMBER | Yeah I really need to continue the work in #1820, this PR has stalled for too long! Last time I worked on this I was struggling a bit on good column auto-sizing and alignment with a pure CSS implementation (i.e., using CSS grid, Another option would be to write a jupyterlab mime render extension. This narrows the supported front-ends, but I guess the issue of front-end theme integration will be easier to solve. Also, it will be possible to add more fancy features later. Did you were at SciPy? I hope you had a great time! I wanted to attend the conference this year but finally I couldn't make it, unfortunately. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
404945296 | https://github.com/pydata/xarray/issues/1627#issuecomment-404945296 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDQwNDk0NTI5Ng== | jhamman 2443309 | 2018-07-13T20:30:05Z | 2018-07-13T20:30:05Z | MEMBER | @benbovy - this came up in conversation today with @shoyer and a number of Jupyter devs. What is the current interest on the subject? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
344062538 | https://github.com/pydata/xarray/issues/1627#issuecomment-344062538 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDM0NDA2MjUzOA== | benbovy 4160723 | 2017-11-13T21:22:28Z | 2017-11-13T21:22:28Z | MEMBER | Yes good points. One part of me (the one that loves every cool, new package) says "let's use |
{ "total_count": 2, "+1": 0, "-1": 0, "laugh": 2, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
344051323 | https://github.com/pydata/xarray/issues/1627#issuecomment-344051323 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDM0NDA1MTMyMw== | shoyer 1217238 | 2017-11-13T20:42:43Z | 2017-11-13T20:42:43Z | MEMBER | The other thing to watch out for is if the vdom Python API is still immature and likely to lead to additional works when it changes in the future. This is somewhat of a judgment call. My sense is that they are taking a careful design to the project but it is still in the early days so it's hard to say for sure. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
344035867 | https://github.com/pydata/xarray/issues/1627#issuecomment-344035867 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDM0NDAzNTg2Nw== | shoyer 1217238 | 2017-11-13T19:47:10Z | 2017-11-13T19:47:19Z | MEMBER | I am OK adding new (optional) Python dependencies like vdom or Jinja2 if that makes implementing and maintaining this easier. If we can solve the problem of generating HTML from vdom as a fallback (https://github.com/nteract/vdom/issues/43) and the vdom developers are supportive for various issues that come up, that could easily be the best option. I would be reluctant to only support vdom output, because there are a lot of legacy notebook viewing interfaces (including various IDEs, cloud hosted notebook environments and rendering on GitHub) that could take a while (years?) to support it. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
344021451 | https://github.com/pydata/xarray/issues/1627#issuecomment-344021451 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDM0NDAyMTQ1MQ== | benbovy 4160723 | 2017-11-13T18:59:28Z | 2017-11-13T18:59:28Z | MEMBER | So we have different options regarding the tools to use for implementing these rich representations:
I'd like to know what are your thoughts. Should we go with |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
342452818 | https://github.com/pydata/xarray/issues/1627#issuecomment-342452818 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDM0MjQ1MjgxOA== | benbovy 4160723 | 2017-11-07T11:20:41Z | 2017-11-07T11:20:41Z | MEMBER | I started working on a new PR (not yet submitted), but before continuing the work I really need to know how best we can include the CSS code in rich outputs for the notebook (e.g., inline CSS or using the It is not really clear to me if it is even supported so I opened an issue on the jupyterlab side (see reference above). |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
341138901 | https://github.com/pydata/xarray/issues/1627#issuecomment-341138901 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDM0MTEzODkwMQ== | fmaussion 10050469 | 2017-11-01T15:22:55Z | 2017-11-01T15:22:55Z | MEMBER |
Yes, but once it's there I'm sure that we'll get bug reports right away if it doesn't work well, because this is a very visual change. Therefore I am almost in favor of pushing this forward as fast as possible and see how it goes, maybe followed by a quick 0.10.1 But since I'm not the one doing the job I'm not allowed to say anything more here ;) |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
341133335 | https://github.com/pydata/xarray/issues/1627#issuecomment-341133335 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDM0MTEzMzMzNQ== | shoyer 1217238 | 2017-11-01T15:05:09Z | 2017-11-01T15:05:09Z | MEMBER |
Yes, probably at this point. But hopefully we can do a shorter release cycle for v0.11. Also, though this is a big visual change, I'm not sure it's actually a breaking change, per se. Only notebook output will change, not programmatic use of |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
341116013 | https://github.com/pydata/xarray/issues/1627#issuecomment-341116013 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDM0MTExNjAxMw== | benbovy 4160723 | 2017-11-01T14:07:24Z | 2017-11-01T14:07:24Z | MEMBER | Sorry for my late reply @shoyer ! Yes I'm happy with this version too, I'll open asap a PR! Unfortunately I hadn't much time to work on this these last two weeks, but I want to put this in my priorities next week. I guess that it is a bit late for v0.10 release which is already on track? I still don't exactly know how much time I'll need to implement this. I haven't thought yet about all implementation details (e.g., how to calculate the width of the variable name column? potential issues with jupyter notebook / jupyterlab...). It might also require some refactoring and/or new public API (e.g., |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
340237652 | https://github.com/pydata/xarray/issues/1627#issuecomment-340237652 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDM0MDIzNzY1Mg== | shoyer 1217238 | 2017-10-29T04:54:32Z | 2017-10-29T04:54:32Z | MEMBER | @benbovy it seems like that discussion has stalled out... are you ready to put together that PR? :) Personally, I'm very happy with your current version. You might even convince me to hold off on the v0.10 release to include it! |
{ "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336513488 | https://github.com/pydata/xarray/issues/1627#issuecomment-336513488 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjUxMzQ4OA== | spencerahill 6200806 | 2017-10-13T17:15:33Z | 2017-10-13T17:15:33Z | CONTRIBUTOR |
ditto wow I can't wait for this to be in! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336510673 | https://github.com/pydata/xarray/issues/1627#issuecomment-336510673 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjUxMDY3Mw== | benbovy 4160723 | 2017-10-13T17:04:07Z | 2017-10-13T17:04:07Z | MEMBER |
Good idea!
Agreed.
The good (or bad?) thing with the marker "a" to the very left is that it is aligned with the drop-down symbols of the main sections, but to me either way is fine. Let's summarize all suggestions so far: Dataset: https://jsfiddle.net/tay08cn9/2/ DataArray: https://jsfiddle.net/43z4v2wt/7/ I think that we're getting close to something good! I'll wait a bit before starting a PR (maybe sometime next week), in case other feedbacks or suggestions come up. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336488056 | https://github.com/pydata/xarray/issues/1627#issuecomment-336488056 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjQ4ODA1Ng== | fujiisoup 6815844 | 2017-10-13T15:36:13Z | 2017-10-13T15:36:13Z | MEMBER |
I like this idea. Looking forward to having it. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336484415 | https://github.com/pydata/xarray/issues/1627#issuecomment-336484415 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjQ4NDQxNQ== | shoyer 1217238 | 2017-10-13T15:23:05Z | 2017-10-13T15:23:05Z | MEMBER | I have a slight proposed tweak on the
Yes, but let's keep it -- it have a nice pure text format (from ncdump) which works especially well with copy & paste.
Yes, I like this general idea -- though we might only show the number when it is collapsed, e.g., |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336477198 | https://github.com/pydata/xarray/issues/1627#issuecomment-336477198 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjQ3NzE5OA== | benbovy 4160723 | 2017-10-13T14:57:06Z | 2017-10-13T15:00:03Z | MEMBER |
In the examples above, you can click on the Given your case, maybe it would be nice to add a rule to show the attribute section collapsed when the number of attributes is too long. If we allow that, then maybe it would be nice to also show the number of items in the section titles, e.g., |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336471850 | https://github.com/pydata/xarray/issues/1627#issuecomment-336471850 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjQ3MTg1MA== | fujiisoup 6815844 | 2017-10-13T14:38:12Z | 2017-10-13T14:38:12Z | MEMBER | This is wonderful! Is it reasonable to add a drop down in the attribute section if there are too many items there? My data sometimes have a long list of attributes and important information about coordinate and data_vars are not seen without scrolling back the page. (This may be a rare case though...) |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336452959 | https://github.com/pydata/xarray/issues/1627#issuecomment-336452959 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjQ1Mjk1OQ== | benbovy 4160723 | 2017-10-13T13:30:44Z | 2017-10-13T13:30:44Z | MEMBER | And for |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336436271 | https://github.com/pydata/xarray/issues/1627#issuecomment-336436271 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjQzNjI3MQ== | benbovy 4160723 | 2017-10-13T12:16:01Z | 2017-10-13T12:16:01Z | MEMBER | New version for
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336396472 | https://github.com/pydata/xarray/issues/1627#issuecomment-336396472 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjM5NjQ3Mg== | fmaussion 10050469 | 2017-10-13T09:11:07Z | 2017-10-13T09:11:07Z | MEMBER | Note that the At least in the notebook, this change would make it obsolete. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336279364 | https://github.com/pydata/xarray/issues/1627#issuecomment-336279364 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjI3OTM2NA== | shoyer 1217238 | 2017-10-12T21:35:39Z | 2017-10-12T21:35:39Z | MEMBER |
Yes, I like that. Possibly clicking on the array values would show the larger preview. I did play around a little with a hover drop down, but the positioning is a little hacky: https://jsfiddle.net/gux879hn/2/ |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336275494 | https://github.com/pydata/xarray/issues/1627#issuecomment-336275494 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjI3NTQ5NA== | benbovy 4160723 | 2017-10-12T21:23:34Z | 2017-10-12T21:23:34Z | MEMBER | A comment regarding the use of javascript: after reading this discussion (https://github.com/bokeh/bokeh/issues/6700) I'm not sure that maintaining a javascript-based repr that works with both jupyterlab and the classic notebook is worth the few fancy features it would provide. I'd rather stick with a pure html/css solution here. It might still co-exist with a full-featured jupyterlab extension for viewing NetCDF files. |
{ "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336270137 | https://github.com/pydata/xarray/issues/1627#issuecomment-336270137 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjI3MDEzNw== | benbovy 4160723 | 2017-10-12T21:10:16Z | 2017-10-12T21:10:16Z | MEMBER |
That would be nice, although I guess that it would require javascript. Alternatively, we can imagine two drop-downs per variable, one for the attributes and one for the full array values (numpy or dask repr). Each would be shown/hidden by two distinct symbols or links, perhaps both located on the right after the preview-values so that we avoid confusion with symbol In the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336216861 | https://github.com/pydata/xarray/issues/1627#issuecomment-336216861 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjIxNjg2MQ== | shoyer 1217238 | 2017-10-12T17:57:45Z | 2017-10-12T17:57:45Z | MEMBER | One more trick we could add for the Dataset repr:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336202067 | https://github.com/pydata/xarray/issues/1627#issuecomment-336202067 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjIwMjA2Nw== | benbovy 4160723 | 2017-10-12T17:06:26Z | 2017-10-12T17:06:26Z | MEMBER |
See https://jsfiddle.net/43z4v2wt/3/
Indeed, I agree now, it's annoying. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336192227 | https://github.com/pydata/xarray/issues/1627#issuecomment-336192227 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjE5MjIyNw== | shoyer 1217238 | 2017-10-12T16:31:25Z | 2017-10-12T16:31:25Z | MEMBER |
Now it just looks a little out of place :). I liked it better closer to the variable name.
Hmm, I'm not sure. I find text that moves very distracting -- I like changing background colors. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336188295 | https://github.com/pydata/xarray/issues/1627#issuecomment-336188295 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjE4ODI5NQ== | shoyer 1217238 | 2017-10-12T16:17:09Z | 2017-10-12T16:17:09Z | MEMBER |
I think this is probably our best option. My main suggestion is it should be possible to click somewhere (maybe on top |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336187799 | https://github.com/pydata/xarray/issues/1627#issuecomment-336187799 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjE4Nzc5OQ== | benbovy 4160723 | 2017-10-12T16:15:29Z | 2017-10-12T16:15:29Z | MEMBER |
Maybe putting the
Changing font-weight instead of background-color works better IMO (same link above). |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336184204 | https://github.com/pydata/xarray/issues/1627#issuecomment-336184204 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjE4NDIwNA== | benbovy 4160723 | 2017-10-12T16:02:59Z | 2017-10-12T16:02:59Z | MEMBER | Before starting a PR on this, I'd like to get the design right (at least the static part) and also to clarify the repr of other xarray objects such as For For
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336169649 | https://github.com/pydata/xarray/issues/1627#issuecomment-336169649 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjE2OTY0OQ== | shoyer 1217238 | 2017-10-12T15:15:59Z | 2017-10-12T15:15:59Z | MEMBER | As long as we're nit-picking style....
I slightly prefer the grayscale you had before -- the section titles are already well detached.
Love it!
It is wonderful to expose this information! I have a slight concern that the
For highlighting, maybe something a little more subtle would work well, either: 1. only highlighting the dimension names below, not the full variables, or 2. only highlight full variables with a matching name, as well as all matching dimensions. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336146728 | https://github.com/pydata/xarray/issues/1627#issuecomment-336146728 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjE0NjcyOA== | rabernat 1197350 | 2017-10-12T14:02:06Z | 2017-10-12T14:02:06Z | MEMBER | Although this could clearly be made more fancy and complicated, I think what you have here would already be a great addition. I love the drop-down attributes (those are missing from the standard repr). Don't hesitate to start a PR! More fanciness could always be added in the future based on user feedback. On Thu, Oct 12, 2017 at 9:01 AM, Benoit Bovy notifications@github.com wrote:
|
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336127376 | https://github.com/pydata/xarray/issues/1627#issuecomment-336127376 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjEyNzM3Ng== | benbovy 4160723 | 2017-10-12T13:00:59Z | 2017-10-12T13:34:32Z | MEMBER | Thanks for the feedback! Here are a few more ideas: https://jsfiddle.net/9ab4c3tr/48/
We might use drop-downs to display other useful information as well, such as the type of array (e.g., dask-array, in-memory numpy.array, etc...) Fancy hover effects would be awesome indeed, although my concern is that too much hover effect would be a source of distraction. A jupyterlab NetCDF viewer extension would be awesome too! It might also leverage phosphor's datagrid (https://github.com/phosphorjs/phosphor/issues/285) to explore the raw data values. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
336001921 | https://github.com/pydata/xarray/issues/1627#issuecomment-336001921 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNjAwMTkyMQ== | darothen 4992424 | 2017-10-12T02:26:05Z | 2017-10-12T02:26:05Z | NONE | Wow, great job @benbovy! With the upcoming move towards Jupyter Lab and a better infrastructure for custom plugins, could this serve as the basis for a "NetCDF Extension" for Jupyter Lab? It would be great if double clicking on a NetCDF file in the JLab file explorer could open up this sort of information, or even a quick and dirty ncview-like plotter. |
{ "total_count": 3, "+1": 3, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
335979107 | https://github.com/pydata/xarray/issues/1627#issuecomment-335979107 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNTk3OTEwNw== | shoyer 1217238 | 2017-10-11T23:41:49Z | 2017-10-11T23:41:49Z | MEMBER | OK, so bad news is that it not possible to select elements other than siblings or descendant tags with CSS. So selecting "cousin" tags like a dimension name at multiple locations in the repr is out. But we could potentially add JavaScript for fancy hover effects. Even if it gets stripped out in many cases (for untrusted notebooks), it should degrade gracefully to the HTML only repr. My main concern would annoying prompts in the notebook interface that ask a user if they want to trust outputs or not. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
335970768 | https://github.com/pydata/xarray/issues/1627#issuecomment-335970768 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNTk3MDc2OA== | shoyer 1217238 | 2017-10-11T22:48:33Z | 2017-10-11T22:48:33Z | MEMBER | OMG indeed this looks fantastic! We should test this on more examples, but I already love it. The underline is a great way to illustrate which variables are dimensions.
Agreed. Notebook viewers tend to sanitize out JavaScript, especially if originating from an unknown source.
This would also be awesome, if possible with pure CSS. I don't know, but I'm going to bug my colleague who does JavaScript visualization. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 | |
335960219 | https://github.com/pydata/xarray/issues/1627#issuecomment-335960219 | https://api.github.com/repos/pydata/xarray/issues/1627 | MDEyOklzc3VlQ29tbWVudDMzNTk2MDIxOQ== | rabernat 1197350 | 2017-10-11T21:53:42Z | 2017-10-11T21:53:42Z | MEMBER | OMG this is so cool! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
html repr of xarray object (for the notebook) 264747372 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 9