home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 336510673

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1627#issuecomment-336510673 https://api.github.com/repos/pydata/xarray/issues/1627 336510673 MDEyOklzc3VlQ29tbWVudDMzNjUxMDY3Mw== 4160723 2017-10-13T17:04:07Z 2017-10-13T17:04:07Z MEMBER

though we might only show the number when it is collapsed

Good idea!

Changes the letter "A" to "a" for attributes

Agreed.

Moves the marker "a" closer to the variable name

The good (or bad?) thing with the marker "a" to the very left is that it is aligned with the drop-down symbols of the main sections, but to me either way is fine.

Let's summarize all suggestions so far:

Dataset: https://jsfiddle.net/tay08cn9/2/ DataArray: https://jsfiddle.net/43z4v2wt/7/

I think that we're getting close to something good!

I'll wait a bit before starting a PR (maybe sometime next week), in case other feedbacks or suggestions come up.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  264747372
Powered by Datasette · Queries took 1.406ms · About: xarray-datasette