issue_comments

Table actions

3 rows where issue = 262930380 and user = 10050469 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • fmaussion · 3 ✖

issue 1

  • fix to_netcdf append bug (GH1215) · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
337930499 https://github.com/pydata/xarray/pull/1609#issuecomment-337930499 https://api.github.com/repos/pydata/xarray/issues/1609 MDEyOklzc3VlQ29tbWVudDMzNzkzMDQ5OQ== fmaussion 10050469 2017-10-19T14:43:48Z 2017-10-19T14:43:48Z MEMBER

Thanks! I like it: simple and in accordance with netcdf4's silent overwriting. It would be cool to describe this behavior this in the documentation somewhere, and add a test that the data is correctly overwritten maybe? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix to_netcdf append bug (GH1215) 262930380
335711382 https://github.com/pydata/xarray/pull/1609#issuecomment-335711382 https://api.github.com/repos/pydata/xarray/issues/1609 MDEyOklzc3VlQ29tbWVudDMzNTcxMTM4Mg== fmaussion 10050469 2017-10-11T07:31:53Z 2017-10-11T07:31:53Z MEMBER

Netcdf4 would overwrite in this situation, and I am also in favor of overwriting as this could be quite a useful usecase:

python from netCDF4 import Dataset with Dataset('test.nc', 'w', format='NETCDF4') as nc: nc.createDimension('lat', 1) nc.createVariable('lat', 'f4', ('lat',)) nc['lat'][:] = 1 with Dataset("test.nc", "a") as nc: nc['lat'][:] = 2

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix to_netcdf append bug (GH1215) 262930380
335411346 https://github.com/pydata/xarray/pull/1609#issuecomment-335411346 https://api.github.com/repos/pydata/xarray/issues/1609 MDEyOklzc3VlQ29tbWVudDMzNTQxMTM0Ng== fmaussion 10050469 2017-10-10T09:12:57Z 2017-10-10T09:12:57Z MEMBER

Thanks @jhamman !

With this fix existing variables will silently be ignored and won't be written, right? Maybe the expected behaviour (or specs) of the "append" option should be written somewhere in the docs and tested to avoid future regressions like we had in https://github.com/pydata/xarray/issues/1215

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix to_netcdf append bug (GH1215) 262930380

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);