home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 335411346

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1609#issuecomment-335411346 https://api.github.com/repos/pydata/xarray/issues/1609 335411346 MDEyOklzc3VlQ29tbWVudDMzNTQxMTM0Ng== 10050469 2017-10-10T09:12:57Z 2017-10-10T09:12:57Z MEMBER

Thanks @jhamman !

With this fix existing variables will silently be ignored and won't be written, right? Maybe the expected behaviour (or specs) of the "append" option should be written somewhere in the docs and tested to avoid future regressions like we had in https://github.com/pydata/xarray/issues/1215

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  262930380
Powered by Datasette · Queries took 79.198ms · About: xarray-datasette