issue_comments

Table actions

4 rows where issue = 257076194 and user = 3639582 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • mrpgraae · 4 ✖

issue 1

  • Support opening password protected datasets over Opendap (Fixes #1068) · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
329829869 https://github.com/pydata/xarray/pull/1570#issuecomment-329829869 https://api.github.com/repos/pydata/xarray/issues/1570 MDEyOklzc3VlQ29tbWVudDMyOTgyOTg2OQ== mrpgraae 3639582 2017-09-15T16:19:09Z 2017-09-15T16:19:09Z CONTRIBUTOR

Thank you too! Cool :) 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support opening password protected datasets over Opendap (Fixes #1068) 257076194
329475573 https://github.com/pydata/xarray/pull/1570#issuecomment-329475573 https://api.github.com/repos/pydata/xarray/issues/1570 MDEyOklzc3VlQ29tbWVudDMyOTQ3NTU3Mw== mrpgraae 3639582 2017-09-14T13:05:41Z 2017-09-14T13:05:41Z CONTRIBUTOR

This looks great to me!

One last suggestion -- can you add a brief note about the ability to access password protected datasets in the opendap section of the docs? http://xarray.pydata.org/en/stable/io.html#opendap

Thanks! It's cool to be able to contribute to a library i use daily.

I added some documentation, please tell me what you think. For the second example, with the NASA URS, i wanted to use a URL that points to an actual NASA dataset, but i couldn't find one that wasn't extremely long. I ended up using that one, which is for a real NASA server, but a non-existant dataset. Hope that's not too confusing. Obviously, the username and password are fake as well :) so maybe it doesn't matter.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support opening password protected datasets over Opendap (Fixes #1068) 257076194
329160391 https://github.com/pydata/xarray/pull/1570#issuecomment-329160391 https://api.github.com/repos/pydata/xarray/issues/1570 MDEyOklzc3VlQ29tbWVudDMyOTE2MDM5MQ== mrpgraae 3639582 2017-09-13T13:02:21Z 2017-09-13T13:02:21Z CONTRIBUTOR

I fixed the documentation stuff and changed the test to one that uses a mock of pydap.client.open_url, like we talked about.

I decided against adding open_urls other keyword arguments to PydapDataStore.open, for the reasons that we discussed and since users can still instantiate their own Pydap dataset and pass that, if they really want to change those parameters.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support opening password protected datasets over Opendap (Fixes #1068) 257076194
328967624 https://github.com/pydata/xarray/pull/1570#issuecomment-328967624 https://api.github.com/repos/pydata/xarray/issues/1570 MDEyOklzc3VlQ29tbWVudDMyODk2NzYyNA== mrpgraae 3639582 2017-09-12T19:59:51Z 2017-09-12T20:02:20Z CONTRIBUTOR

Thank you for the fast review!

but if there are a few other optional keyword arguments to complete the function signature, then sure, that would be fine. I would definitely avoid using **kwargs, because that precludes the ability for us to add other xarray specific options at some point in the future.

One of the reasons i was unsure about adding the other keyword arguments, is that I'm not entirely sure if changing any of them from their default values will break the interface with xarray. But i guess you could argue that if users are changing these parameters, they probably know what they are doing.

Then there's also the timeout parameter, for which I think we will need to import some module within pydap just to get DEFAULT_TIMEOUT. That seems a bit awkward? We could also just leave that one out.

I definitely see your point with **kwargs, I had a feeling that would be a bad idea.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support opening password protected datasets over Opendap (Fixes #1068) 257076194

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);