issue_comments: 328967624

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1570#issuecomment-328967624 https://api.github.com/repos/pydata/xarray/issues/1570 328967624 MDEyOklzc3VlQ29tbWVudDMyODk2NzYyNA== 3639582 2017-09-12T19:59:51Z 2017-09-12T20:02:20Z CONTRIBUTOR

Thank you for the fast review!

but if there are a few other optional keyword arguments to complete the function signature, then sure, that would be fine. I would definitely avoid using **kwargs, because that precludes the ability for us to add other xarray specific options at some point in the future.

One of the reasons i was unsure about adding the other keyword arguments, is that I'm not entirely sure if changing any of them from their default values will break the interface with xarray. But i guess you could argue that if users are changing these parameters, they probably know what they are doing.

Then there's also the timeout parameter, for which I think we will need to import some module within pydap just to get DEFAULT_TIMEOUT. That seems a bit awkward? We could also just leave that one out.

I definitely see your point with **kwargs, I had a feeling that would be a bad idea.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   257076194