home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 329160391

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1570#issuecomment-329160391 https://api.github.com/repos/pydata/xarray/issues/1570 329160391 MDEyOklzc3VlQ29tbWVudDMyOTE2MDM5MQ== 3639582 2017-09-13T13:02:21Z 2017-09-13T13:02:21Z CONTRIBUTOR

I fixed the documentation stuff and changed the test to one that uses a mock of pydap.client.open_url, like we talked about.

I decided against adding open_urls other keyword arguments to PydapDataStore.open, for the reasons that we discussed and since users can still instantiate their own Pydap dataset and pass that, if they really want to change those parameters.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  257076194
Powered by Datasette · Queries took 1.485ms · About: xarray-datasette