issue_comments

Table actions

2 rows where issue = 1685803922 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • dcherian · 2 ✖

issue 1

  • Fill values in time arrays (numpy.datetime64) are lost in zarr · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1528072972 https://github.com/pydata/xarray/issues/7790#issuecomment-1528072972 https://api.github.com/repos/pydata/xarray/issues/7790 IC_kwDOAMm_X85bFIsM dcherian 2448579 2023-04-28T20:43:44Z 2023-04-28T20:43:44Z MEMBER 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   Fill values in time arrays (numpy.datetime64) are lost in zarr 1685803922
1526224630 https://github.com/pydata/xarray/issues/7790#issuecomment-1526224630 https://api.github.com/repos/pydata/xarray/issues/7790 IC_kwDOAMm_X85a-Fb2 dcherian 2448579 2023-04-27T19:18:12Z 2023-04-27T19:18:12Z MEMBER

I think the issue is that we're always running "CF encoding" which is more appropriate for netCDF4 than Zarr, since Zarr supports datetime64 natively. And currently there's no way to control whether the datetime encoder is applied or not, we just look at the dtype: https://github.com/pydata/xarray/blob/0f4e99d036b0d6d76a3271e6191eacbc9922662f/xarray/coding/times.py#L697-L704

I think the right way to fix this is to allow the user to run the encode and write steps separately, with the encoding steps being controllable: https://github.com/pydata/xarray/issues/4412

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fill values in time arrays (numpy.datetime64) are lost in zarr 1685803922

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);