home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1526224630

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/7790#issuecomment-1526224630 https://api.github.com/repos/pydata/xarray/issues/7790 1526224630 IC_kwDOAMm_X85a-Fb2 2448579 2023-04-27T19:18:12Z 2023-04-27T19:18:12Z MEMBER

I think the issue is that we're always running "CF encoding" which is more appropriate for netCDF4 than Zarr, since Zarr supports datetime64 natively. And currently there's no way to control whether the datetime encoder is applied or not, we just look at the dtype: https://github.com/pydata/xarray/blob/0f4e99d036b0d6d76a3271e6191eacbc9922662f/xarray/coding/times.py#L697-L704

I think the right way to fix this is to allow the user to run the encode and write steps separately, with the encoding steps being controllable: https://github.com/pydata/xarray/issues/4412

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1685803922
Powered by Datasette · Queries took 0.597ms · About: xarray-datasette