issue_comments

Table actions

3 rows where issue = 1550109629 and user = 6213168 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • crusaderky · 3 ✖

issue 1

  • bump minimum versions, drop py38 · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1517892096 https://github.com/pydata/xarray/pull/7461#issuecomment-1517892096 https://api.github.com/repos/pydata/xarray/issues/7461 IC_kwDOAMm_X85aeTIA crusaderky 6213168 2023-04-21T14:07:08Z 2023-04-21T14:07:08Z MEMBER

It just occurred to me that xarray dropped Python 3.8 3 months before what NEP-29 recommends. I think this is a problem. Let's continue this discussion on #7777.

 
{
    "total_count": 3,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 1,
    "heart": 0,
    "rocket": 0,
    "eyes": 2
}
   bump minimum versions, drop py38 1550109629
1515950820 https://github.com/pydata/xarray/pull/7461#issuecomment-1515950820 https://api.github.com/repos/pydata/xarray/issues/7461 IC_kwDOAMm_X85aW5Lk crusaderky 6213168 2023-04-20T08:43:19Z 2023-04-20T08:43:19Z MEMBER

This also breaks xarray on ubuntu 20.04 which ships with Python 3.8 and is supported until April 2025. Python 3.8 is also supported at least until October 2024.

Not investing effort to support 5 years old dependencies was a very conscious decision. This is not something unique we do; we simply adhere to NEP29: https://numpy.org/neps/nep-0029-deprecation_policy.html

If for whatever reason you want to use python shipped by ubuntu 20.04, as opposed to conda/venv/poetry/whatever, you should also be prepared to stick to older versions of the python packages. Note that 5 years is the duration of security support. I'm not personally aware of security issues in xarray since Python 3.8 was abandoned (I've been a bit out of the loop and I could be proven wrong), but in the unlikely event that one should arise in xarray, we would consider a backport to Python 3.8.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump minimum versions, drop py38 1550109629
1507163165 https://github.com/pydata/xarray/pull/7461#issuecomment-1507163165 https://api.github.com/repos/pydata/xarray/issues/7461 IC_kwDOAMm_X85Z1Xwd crusaderky 6213168 2023-04-13T15:21:52Z 2023-04-13T15:21:52Z MEMBER

I assume you have given this a lot of thought, but imho the minimum dependency versions should be decided according to features needed, not timing.

It's not based on timing. The policy is there so that, when a developer finds that they have to do extra labour to support an old version of a dependency, they can instead drop the support for the old version without needing to seek approval from the maintainers.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump minimum versions, drop py38 1550109629

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);