issue_comments
18 rows where issue = 1550109629 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: reactions, created_at (date), updated_at (date)
issue 1
- bump minimum versions, drop py38 · 18 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
1517892096 | https://github.com/pydata/xarray/pull/7461#issuecomment-1517892096 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85aeTIA | crusaderky 6213168 | 2023-04-21T14:07:08Z | 2023-04-21T14:07:08Z | MEMBER | It just occurred to me that xarray dropped Python 3.8 3 months before what NEP-29 recommends. I think this is a problem. Let's continue this discussion on #7777. |
{ "total_count": 3, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 1, "heart": 0, "rocket": 0, "eyes": 2 } |
bump minimum versions, drop py38 1550109629 | |
1515950820 | https://github.com/pydata/xarray/pull/7461#issuecomment-1515950820 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85aW5Lk | crusaderky 6213168 | 2023-04-20T08:43:19Z | 2023-04-20T08:43:19Z | MEMBER |
Not investing effort to support 5 years old dependencies was a very conscious decision. This is not something unique we do; we simply adhere to NEP29: https://numpy.org/neps/nep-0029-deprecation_policy.html If for whatever reason you want to use python shipped by ubuntu 20.04, as opposed to conda/venv/poetry/whatever, you should also be prepared to stick to older versions of the python packages. Note that 5 years is the duration of security support. I'm not personally aware of security issues in xarray since Python 3.8 was abandoned (I've been a bit out of the loop and I could be proven wrong), but in the unlikely event that one should arise in xarray, we would consider a backport to Python 3.8. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1513228411 | https://github.com/pydata/xarray/pull/7461#issuecomment-1513228411 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85aMgh7 | MuellerSeb 19690642 | 2023-04-18T14:08:36Z | 2023-04-18T14:08:36Z | NONE | This also breaks xarray on ubuntu 20.04 which ships with Python 3.8 and is supported until April 2025. Python 3.8 is also supported at least until October 2024. Together with the Pandas 2 issue (that I am also running into), this is very unfortunate. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1507176030 | https://github.com/pydata/xarray/pull/7461#issuecomment-1507176030 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85Z1a5e | st-bender 28786187 | 2023-04-13T15:30:28Z | 2023-04-13T15:30:28Z | CONTRIBUTOR | Hi,
That's not how I interpret the link given by @dcherian, which states "rolling" minimum versions based on age. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1507163165 | https://github.com/pydata/xarray/pull/7461#issuecomment-1507163165 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85Z1Xwd | crusaderky 6213168 | 2023-04-13T15:21:52Z | 2023-04-13T15:21:52Z | MEMBER |
It's not based on timing. The policy is there so that, when a developer finds that they have to do extra labour to support an old version of a dependency, they can instead drop the support for the old version without needing to seek approval from the maintainers. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1507150495 | https://github.com/pydata/xarray/pull/7461#issuecomment-1507150495 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85Z1Uqf | st-bender 28786187 | 2023-04-13T15:13:28Z | 2023-04-13T15:13:28Z | CONTRIBUTOR | Hi @dcherian
I assume you have given this a lot of thought, but imho the minimum dependency versions should be decided according to features needed, not timing.
Thanks for the pointer.
I am not sure why, maybe I was updating too eagerly before the feedstock was fixed, but
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1503517162 | https://github.com/pydata/xarray/pull/7461#issuecomment-1503517162 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85Zndnq | dcherian 2448579 | 2023-04-11T14:50:11Z | 2023-04-11T14:50:11Z | MEMBER | Here is our support policy for versions: https://docs.xarray.dev/en/stable/getting-started-guide/installing.html#minimum-dependency-versions though I think we dropped py38 too early. For your current issue, I'm surprised this patch didn't fix it: https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/429 cc @hmaarrfk @ocefpaf |
{ "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1503393910 | https://github.com/pydata/xarray/pull/7461#issuecomment-1503393910 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85Zm_h2 | st-bender 28786187 | 2023-04-11T13:50:42Z | 2023-04-11T13:50:42Z | CONTRIBUTOR | Hi,
Just to let you know that this change breaks python 3.8 setups with automatic updates becuase the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1405308596 | https://github.com/pydata/xarray/pull/7461#issuecomment-1405308596 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85Tw060 | dcherian 2448579 | 2023-01-26T16:57:02Z | 2023-01-26T16:57:02Z | MEMBER | Thanks @jhamman |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1404140613 | https://github.com/pydata/xarray/pull/7461#issuecomment-1404140613 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85TsXxF | headtr1ck 43316012 | 2023-01-25T19:43:51Z | 2023-01-25T19:43:51Z | COLLABORATOR | I have very few time lately but I should be able to have a look in the next few days of you can wait a bit longer. But also fine if you merge now and I check this dtype thing later. |
{ "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1402872179 | https://github.com/pydata/xarray/pull/7461#issuecomment-1402872179 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85TniFz | jhamman 2443309 | 2023-01-25T00:23:38Z | 2023-01-25T00:23:38Z | MEMBER | After thinking about this a bit more, I suggest we leave the numpy dtype issue for later. I'd rather not import the private dtypes (at least as part of this PR). So plan for going forward. @dcherian has already approved this PR. I think it would be good to get one more reviewer to double check things here. Then, assuming things are looking good, I'd like to merge. I will open an issue about the dtype import to track that separately. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1402594544 | https://github.com/pydata/xarray/pull/7461#issuecomment-1402594544 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85TmeTw | Illviljan 14371165 | 2023-01-24T20:27:02Z | 2023-01-24T20:27:02Z | MEMBER | I'm not sure at all about this but maybe you're supposed to go back to something like this? https://github.com/pydata/xarray/pull/6834/commits/7fcc11ffb20583caf1976191997bd2a7525ac218#diff-791d93adb64d0986ac499ce1ba831cc95b4ffbde0dfe98b28d929935b05d7134L49
|
{ "total_count": 2, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 1, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1402493257 | https://github.com/pydata/xarray/pull/7461#issuecomment-1402493257 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85TmFlJ | jhamman 2443309 | 2023-01-24T19:41:24Z | 2023-01-24T19:41:24Z | MEMBER | @Illviljan, @shoyer, or @keewis - do any of you have suggestions for how to respond to this comment? https://github.com/pydata/xarray/blob/b21f62ee37eea3650a58e9ffa3a7c9f4ae83006b/xarray/core/types.py#L57-L62 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1398677525 | https://github.com/pydata/xarray/pull/7461#issuecomment-1398677525 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85TXiAV | jhamman 2443309 | 2023-01-20T17:07:02Z | 2023-01-20T20:51:26Z | MEMBER | I'm doing a bit of an audit on our conditional version logic. A few questions that I don't know how to resolve on my own.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1398773751 | https://github.com/pydata/xarray/pull/7461#issuecomment-1398773751 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85TX5f3 | spencerkclark 6628425 | 2023-01-20T18:24:53Z | 2023-01-20T18:24:53Z | MEMBER | @jhamman nice -- thanks for noting that. I think you can replace and then remove any reference to |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1398702023 | https://github.com/pydata/xarray/pull/7461#issuecomment-1398702023 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85TXn_H | Illviljan 14371165 | 2023-01-20T17:21:34Z | 2023-01-20T17:21:34Z | MEMBER | @jhamman, I believe you should simply remove Commit testing the hack: https://github.com/pydata/xarray/pull/7285/commits/d8bef27e54aa9e81873d5d64fca6a1d4d324ca62 |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1398596372 | https://github.com/pydata/xarray/pull/7461#issuecomment-1398596372 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85TXOMU | dcherian 2448579 | 2023-01-20T15:59:36Z | 2023-01-20T15:59:36Z | MEMBER |
Numpy is about to do it too: https://github.com/numpy/numpy/pull/23053 so I'm :+1: on it. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 | |
1398582379 | https://github.com/pydata/xarray/pull/7461#issuecomment-1398582379 | https://api.github.com/repos/pydata/xarray/issues/7461 | IC_kwDOAMm_X85TXKxr | jhamman 2443309 | 2023-01-20T15:46:50Z | 2023-01-20T15:46:50Z | MEMBER | @pydata/xarray - This PR is ready for discussion / review. Our minimum versions policy says its time to drop Python 3.8. But do we want to do that? I'll note that work is already underway to support Python 3.11 (#7316). |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump minimum versions, drop py38 1550109629 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 8