issue_comments

Table actions

3 rows where issue = 1550109629 and user = 28786187 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • st-bender · 3 ✖

issue 1

  • bump minimum versions, drop py38 · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1507176030 https://github.com/pydata/xarray/pull/7461#issuecomment-1507176030 https://api.github.com/repos/pydata/xarray/issues/7461 IC_kwDOAMm_X85Z1a5e st-bender 28786187 2023-04-13T15:30:28Z 2023-04-13T15:30:28Z CONTRIBUTOR

Hi,

I assume you have given this a lot of thought, but imho the minimum dependency versions should be decided according to features needed, not timing.

It's not based on timing. The policy is there so that, when a developer finds that they have to do extra labour to support an old version of a dependency, they can instead drop the support for the old version without needing to seek approval from the maintainers.

That's not how I interpret the link given by @dcherian, which states "rolling" minimum versions based on age.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump minimum versions, drop py38 1550109629
1507150495 https://github.com/pydata/xarray/pull/7461#issuecomment-1507150495 https://api.github.com/repos/pydata/xarray/issues/7461 IC_kwDOAMm_X85Z1Uqf st-bender 28786187 2023-04-13T15:13:28Z 2023-04-13T15:13:28Z CONTRIBUTOR

Hi @dcherian

Here is our support policy for versions: https://docs.xarray.dev/en/stable/getting-started-guide/installing.html#minimum-dependency-versions though I think we dropped py38 too early.

I assume you have given this a lot of thought, but imho the minimum dependency versions should be decided according to features needed, not timing.

For your current issue, I'm surprised this patch didn't fix it: conda-forge/conda-forge-repodata-patches-feedstock#429

Thanks for the pointer. I am not sure why, maybe I was updating too eagerly before the feedstock was fixed, but mamba update --all on py38 pulled pandas 2.0 without updating xarray.

python3.8 -m pip install xarray will result in incompatible versions.

cc @hmaarrfk @ocefpaf

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump minimum versions, drop py38 1550109629
1503393910 https://github.com/pydata/xarray/pull/7461#issuecomment-1503393910 https://api.github.com/repos/pydata/xarray/issues/7461 IC_kwDOAMm_X85Zm_h2 st-bender 28786187 2023-04-11T13:50:42Z 2023-04-11T13:50:42Z CONTRIBUTOR

Hi, Just to let you know that this change breaks python 3.8 setups with automatic updates becuase the pandas version is not restricted, so it will be happily updated to version 2 or higher. Which in turn is not compatible with xarray < 2023.2, which cannot be installed on python 3.8 because of this change. Don't know why the min python version was changed, this PR doesn't say why it was necessary. Cheers.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump minimum versions, drop py38 1550109629

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);