home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1398677525

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7461#issuecomment-1398677525 https://api.github.com/repos/pydata/xarray/issues/7461 1398677525 IC_kwDOAMm_X85TXiAV 2443309 2023-01-20T17:07:02Z 2023-01-20T20:51:26Z MEMBER

I'm doing a bit of an audit on our conditional version logic. A few questions that I don't know how to resolve on my own.

  • [ ] _SupportsDType - @headtr1ck, do you have a suggestion for how to handle this comment: https://github.com/pydata/xarray/blob/b21f62ee37eea3650a58e9ffa3a7c9f4ae83006b/xarray/core/types.py#L57-L62

  • [x] timedeltas - @spencerkclark, do you have a suggestion for how to handle this comment: https://github.com/pydata/xarray/blob/b21f62ee37eea3650a58e9ffa3a7c9f4ae83006b/xarray/coding/times.py#L358-L363

  • [x] GenericAlias - @Illviljan, do you have a suggestion for how to handle this comment: https://github.com/pydata/xarray/blob/b4e3cbcf17374b68477ed3ff7a8a52c82837ad91/xarray/core/coordinates.py#L31-L40

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1550109629
Powered by Datasette · Queries took 78.46ms · About: xarray-datasette