issue_comments

Table actions

2 rows where issue = 1505375386 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • implement `isnull` using `full_like` instead of `zeros_like` · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1383214949 https://github.com/pydata/xarray/pull/7395#issuecomment-1383214949 https://api.github.com/repos/pydata/xarray/issues/7395 IC_kwDOAMm_X85Sci9l dcherian 2448579 2023-01-15T18:07:10Z 2023-01-15T18:07:10Z MEMBER

So not sure how to proceed?

I think it'd be OK to have some compatibility code with hardcoded version numbers. It's simpler and more user-friendly than the other alternatives.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implement `isnull` using `full_like` instead of `zeros_like` 1505375386
1362191892 https://github.com/pydata/xarray/pull/7395#issuecomment-1362191892 https://api.github.com/repos/pydata/xarray/issues/7395 IC_kwDOAMm_X85RMWYU keewis 14808389 2022-12-21T22:46:53Z 2022-12-21T22:46:53Z MEMBER

The test failures are real, unfortunately. pint's implementation of full_like explicitly defines the parameters, among them subok which the dask implementation does not support.

That means that update strategies might become tricky: the new version of pint would change the behavior and require us to implement isnull using full_like, but a bug in pint prevents that from working on dask. So not sure how to proceed?

One way might be to have pint issue a bugfix release first, wait on a release of xarray that contains this change, then release a version with the change in behavior (or deprecate / allow switching between the old / new behavior).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implement `isnull` using `full_like` instead of `zeros_like` 1505375386

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);