issue_comments: 1362191892

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7395#issuecomment-1362191892 https://api.github.com/repos/pydata/xarray/issues/7395 1362191892 IC_kwDOAMm_X85RMWYU 14808389 2022-12-21T22:46:53Z 2022-12-21T22:46:53Z MEMBER

The test failures are real, unfortunately. pint's implementation of full_like explicitly defines the parameters, among them subok which the dask implementation does not support.

That means that update strategies might become tricky: the new version of pint would change the behavior and require us to implement isnull using full_like, but a bug in pint prevents that from working on dask. So not sure how to proceed?

One way might be to have pint issue a bugfix release first, wait on a release of xarray that contains this change, then release a version with the change in behavior (or deprecate / allow switching between the old / new behavior).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1505375386