issues: 1505375386

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1505375386 PR_kwDOAMm_X85F6MBQ 7395 implement `isnull` using `full_like` instead of `zeros_like` 14808389 closed 0     2 2022-12-20T22:07:30Z 2024-01-28T14:19:26Z 2024-01-23T18:29:14Z MEMBER   0 pydata/xarray/pulls/7395

After changing the behavior of the implementation of *_like in pint, it seems comparisons fail now. As it turns out, this is because we're using zeros_like to return all-False arrays from isnull for input with non-nullable dtypes.

I'd argue that python full_like(data, dtype=bool, fill_value=False) is a little bit easier to understand than python zeros_like(data, dtype=bool) as the latter requires knowledge about the bit representation of False, so the change is not only to get pint to work properly.

  • [x] Tests added
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7395/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables