issue_comments

Table actions

3 rows where issue = 1388326248 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 3

issue 1

  • xarray allows several types for netcdf attributes. Is it expected ? · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1267558344 https://github.com/pydata/xarray/issues/7093#issuecomment-1267558344 https://api.github.com/repos/pydata/xarray/issues/7093 IC_kwDOAMm_X85LjWfI acrosby 865212 2022-10-04T20:46:32Z 2022-10-04T20:46:32Z NONE

I believe NetCDF, CF-Conventions, and xarray should all be considered independently. It is not necessarily the responsibility of xarray serialization to ensure a CF-complaint file...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray allows several types for netcdf attributes. Is it expected ? 1388326248
1264596449 https://github.com/pydata/xarray/issues/7093#issuecomment-1264596449 https://api.github.com/repos/pydata/xarray/issues/7093 IC_kwDOAMm_X85LYDXh ghislainp 10563614 2022-10-02T09:37:47Z 2022-10-02T09:37:47Z CONTRIBUTOR
  • this issue was submitted because of https://github.com/pydata/xarray/pull/7085#discussion_r981443796
  • I also tend to agree that this behavior is fine for the non-specific netcdf attributes.
  • For specific attributes as unit and _FillValue, is it also fine ? I would expect that Dataset.to_netcdf check the type (string for unit and the type of the variable for _FillValue and raise at least a warning. It is currently possible to save a number for the unit... Is the resulting netcdf CF-compliant ?
  • if any kind of types for attributes is allowed, this requires to chase bugs of the kind solved in #7085.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray allows several types for netcdf attributes. Is it expected ? 1388326248
1264566866 https://github.com/pydata/xarray/issues/7093#issuecomment-1264566866 https://api.github.com/repos/pydata/xarray/issues/7093 IC_kwDOAMm_X85LX8JS headtr1ck 43316012 2022-10-02T06:46:08Z 2022-10-02T06:46:08Z COLLABORATOR

What exactly do you mean by netcdf attributes? The special meaning ones like units, _FillValue or long_name?

In general xarray is quite relaxed on what users put into the attrs, internally it is simply a dict of anything (see e.g. #7111 where people put in recursive DataArrays).

As soon as you try to write it into a netCDF it has to be serializable, but that's why it raises an error.

Personally I think the current behavior is fine (ofc, plotting etc should be able to deal with non-standard units etc.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray allows several types for netcdf attributes. Is it expected ? 1388326248

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);