issue_comments: 1264566866

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/7093#issuecomment-1264566866 https://api.github.com/repos/pydata/xarray/issues/7093 1264566866 IC_kwDOAMm_X85LX8JS 43316012 2022-10-02T06:46:08Z 2022-10-02T06:46:08Z COLLABORATOR

What exactly do you mean by netcdf attributes? The special meaning ones like units, _FillValue or long_name?

In general xarray is quite relaxed on what users put into the attrs, internally it is simply a dict of anything (see e.g. #7111 where people put in recursive DataArrays).

As soon as you try to write it into a netCDF it has to be serializable, but that's why it raises an error.

Personally I think the current behavior is fine (ofc, plotting etc should be able to deal with non-standard units etc.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1388326248