issue_comments: 1264596449

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/7093#issuecomment-1264596449 https://api.github.com/repos/pydata/xarray/issues/7093 1264596449 IC_kwDOAMm_X85LYDXh 10563614 2022-10-02T09:37:47Z 2022-10-02T09:37:47Z CONTRIBUTOR
  • this issue was submitted because of https://github.com/pydata/xarray/pull/7085#discussion_r981443796
  • I also tend to agree that this behavior is fine for the non-specific netcdf attributes.
  • For specific attributes as unit and _FillValue, is it also fine ? I would expect that Dataset.to_netcdf check the type (string for unit and the type of the variable for _FillValue and raise at least a warning. It is currently possible to save a number for the unit... Is the resulting netcdf CF-compliant ?
  • if any kind of types for attributes is allowed, this requires to chase bugs of the kind solved in #7085.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1388326248