issue_comments

Table actions

5 rows where issue = 116349205 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 5 ✖

issue 1

  • More control on cmap params · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
156864017 https://github.com/pydata/xarray/pull/655#issuecomment-156864017 https://api.github.com/repos/pydata/xarray/issues/655 MDEyOklzc3VlQ29tbWVudDE1Njg2NDAxNw== shoyer 1217238 2015-11-15T22:20:04Z 2015-11-15T22:20:04Z MEMBER

Thanks @fmaussion! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More control on cmap params 116349205
156861015 https://github.com/pydata/xarray/pull/655#issuecomment-156861015 https://api.github.com/repos/pydata/xarray/issues/655 MDEyOklzc3VlQ29tbWVudDE1Njg2MTAxNQ== shoyer 1217238 2015-11-15T22:07:02Z 2015-11-15T22:07:02Z MEMBER

OK, this looks good to me. I'm just waiting on @mwaskom before merging.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More control on cmap params 116349205
156758224 https://github.com/pydata/xarray/pull/655#issuecomment-156758224 https://api.github.com/repos/pydata/xarray/issues/655 MDEyOklzc3VlQ29tbWVudDE1Njc1ODIyNA== shoyer 1217238 2015-11-14T23:36:18Z 2015-11-14T23:36:18Z MEMBER

@fmaussion try pulling the latest master and rebasing this branch? If that doesn't work for you, I can apply this change manually.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More control on cmap params 116349205
156611108 https://github.com/pydata/xarray/pull/655#issuecomment-156611108 https://api.github.com/repos/pydata/xarray/issues/655 MDEyOklzc3VlQ29tbWVudDE1NjYxMTEwOA== shoyer 1217238 2015-11-14T02:25:02Z 2015-11-14T02:25:02Z MEMBER

This looks good to be -- the tests seem to nail this down pretty well, even though the logic has indeed become more convoluted. @mwaskom any concerns from your side?

Please do do a rebase/squash (most importantly to eliminate any commits that failed CI) and also please add a shirt change note to a "breaking changes" section of the what's new docs. This will probably not make it in until the 0.7 release (which probably will be our next release), but just go ahead and put it in the 0.6.2 notes for now and we'll reorganize later.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More control on cmap params 116349205
155918906 https://github.com/pydata/xarray/pull/655#issuecomment-155918906 https://api.github.com/repos/pydata/xarray/issues/655 MDEyOklzc3VlQ29tbWVudDE1NTkxODkwNg== shoyer 1217238 2015-11-11T21:43:03Z 2015-11-11T21:43:03Z MEMBER
  1. The only safe times to assume a diverging colormap is when vmin = -vmax or when center is not None. If you want a diverging colormap for other situations, you need to specify cmap in the plot call.

I actually agree with @mwaskom here. I would not make inferring a diverging colormap dependent on vmin = -vmax (assuming center=0). It's useful to be able to control the bounds of a diverging colormap by only setting one of vmin and vmax, and comparing vmin - center == center - vmax seems prone to numerical precision issues.

I do agree with principles 1 and 2, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More control on cmap params 116349205

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);