issue_comments: 155918906

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/655#issuecomment-155918906 https://api.github.com/repos/pydata/xarray/issues/655 155918906 MDEyOklzc3VlQ29tbWVudDE1NTkxODkwNg== 1217238 2015-11-11T21:43:03Z 2015-11-11T21:43:03Z MEMBER
  1. The only safe times to assume a diverging colormap is when vmin = -vmax or when center is not None. If you want a diverging colormap for other situations, you need to specify cmap in the plot call.

I actually agree with @mwaskom here. I would not make inferring a diverging colormap dependent on vmin = -vmax (assuming center=0). It's useful to be able to control the bounds of a diverging colormap by only setting one of vmin and vmax, and comparing vmin - center == center - vmax seems prone to numerical precision issues.

I do agree with principles 1 and 2, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   116349205