home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 156611108

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/655#issuecomment-156611108 https://api.github.com/repos/pydata/xarray/issues/655 156611108 MDEyOklzc3VlQ29tbWVudDE1NjYxMTEwOA== 1217238 2015-11-14T02:25:02Z 2015-11-14T02:25:02Z MEMBER

This looks good to be -- the tests seem to nail this down pretty well, even though the logic has indeed become more convoluted. @mwaskom any concerns from your side?

Please do do a rebase/squash (most importantly to eliminate any commits that failed CI) and also please add a shirt change note to a "breaking changes" section of the what's new docs. This will probably not make it in until the 0.7 release (which probably will be our next release), but just go ahead and put it in the 0.6.2 notes for now and we'll reorganize later.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  116349205
Powered by Datasette · Queries took 0.756ms · About: xarray-datasette