issue_comments

Table actions

6 rows where author_association = "NONE" and issue = 220011864 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • Add DatetimeAccessor for accessing datetime fields via `.dt` attribute · 6 ✖

author_association 1

  • NONE · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
294829429 https://github.com/pydata/xarray/pull/1356#issuecomment-294829429 https://api.github.com/repos/pydata/xarray/issues/1356 MDEyOklzc3VlQ29tbWVudDI5NDgyOTQyOQ== darothen 4992424 2017-04-18T12:53:01Z 2017-04-18T12:53:01Z NONE

Alrighty, patched and ready for a final look-over! I appreciate the help and patience, @shoyer!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add DatetimeAccessor for accessing datetime fields via `.dt` attribute 220011864
294628295 https://github.com/pydata/xarray/pull/1356#issuecomment-294628295 https://api.github.com/repos/pydata/xarray/issues/1356 MDEyOklzc3VlQ29tbWVudDI5NDYyODI5NQ== darothen 4992424 2017-04-17T23:44:08Z 2017-04-17T23:44:08Z NONE

Turns out it was easy enough to add an accessor for ds['time.time']; that's already provided via pandas.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add DatetimeAccessor for accessing datetime fields via `.dt` attribute 220011864
294520064 https://github.com/pydata/xarray/pull/1356#issuecomment-294520064 https://api.github.com/repos/pydata/xarray/issues/1356 MDEyOklzc3VlQ29tbWVudDI5NDUyMDA2NA== darothen 4992424 2017-04-17T16:21:19Z 2017-04-17T16:21:19Z NONE

There's a test-case relating to #367 (test_virtual_variable_same_name) which is causing me a bit of grief as I re-factor the virtual variable logic. Should we really be able to access variables like ds['time.time']? This seems to break the logic of what a virtual variable does, and was implemented to help out with time GroupBys and resampling (something I'll eventually get around to finishing up a refactor for - #1272).

Two options for fixing:

  1. add a "time" field to DateTimeAccessor.
  2. add some additional if-then-else logic to _get_virtual_variable.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add DatetimeAccessor for accessing datetime fields via `.dt` attribute 220011864
293881177 https://github.com/pydata/xarray/pull/1356#issuecomment-293881177 https://api.github.com/repos/pydata/xarray/issues/1356 MDEyOklzc3VlQ29tbWVudDI5Mzg4MTE3Nw== darothen 4992424 2017-04-13T12:26:24Z 2017-04-13T12:26:24Z NONE

Finished clean-up, added some documentation, etc. I mangled resolving a merge conflict with my update to whats-new.rst (5ae4e08) in terms of the commit text, but other than that I think we're getting closer to finishing this.

wrt to the virtual variables, I think some more thinking is necessary so we can come up with a plan of approach. Do we want to deprecate this feature entirely? Do we just want to wrap the datetime component virtual variables to the .dt accessor if they're datetime-like? We could very easily do the latter for 0.9.3, but maybe we should target a future major release to deprecate the virtual variables and instead encourage adding a few specialized (but commonly-used) accessors to xarray?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add DatetimeAccessor for accessing datetime fields via `.dt` attribute 220011864
293280073 https://github.com/pydata/xarray/pull/1356#issuecomment-293280073 https://api.github.com/repos/pydata/xarray/issues/1356 MDEyOklzc3VlQ29tbWVudDI5MzI4MDA3Mw== darothen 4992424 2017-04-11T14:25:27Z 2017-04-11T14:25:27Z NONE

Updated with support for multi-dimensional time data stored as dask array.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add DatetimeAccessor for accessing datetime fields via `.dt` attribute 220011864
292569100 https://github.com/pydata/xarray/pull/1356#issuecomment-292569100 https://api.github.com/repos/pydata/xarray/issues/1356 MDEyOklzc3VlQ29tbWVudDI5MjU2OTEwMA== darothen 4992424 2017-04-07T15:30:43Z 2017-04-07T15:30:43Z NONE

@shoyer I corrected things based on your comments. The last commit is an attempt to refactor things to match the way that methods like rolling/groupby functions are injected into the class; this might be totally superfluous here, but I thought it was worth trying.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add DatetimeAccessor for accessing datetime fields via `.dt` attribute 220011864

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);