issue_comments: 294520064

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1356#issuecomment-294520064 https://api.github.com/repos/pydata/xarray/issues/1356 294520064 MDEyOklzc3VlQ29tbWVudDI5NDUyMDA2NA== 4992424 2017-04-17T16:21:19Z 2017-04-17T16:21:19Z NONE

There's a test-case relating to #367 (test_virtual_variable_same_name) which is causing me a bit of grief as I re-factor the virtual variable logic. Should we really be able to access variables like ds['time.time']? This seems to break the logic of what a virtual variable does, and was implemented to help out with time GroupBys and resampling (something I'll eventually get around to finishing up a refactor for - #1272).

Two options for fixing:

  1. add a "time" field to DateTimeAccessor.
  2. add some additional if-then-else logic to _get_virtual_variable.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   220011864