issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 860418546 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • N-dimensional boolean indexing · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
824505721 https://github.com/pydata/xarray/issues/5179#issuecomment-824505721 https://api.github.com/repos/pydata/xarray/issues/5179 MDEyOklzc3VlQ29tbWVudDgyNDUwNTcyMQ== shoyer 1217238 2021-04-22T03:11:21Z 2021-04-22T03:11:21Z MEMBER

@max-sixty and I have been having some more discussion about whether this is what ds[key] should do for N-dimensional boolean indexing over in #1887.

But regardless of what we want boolean indexing with [] to do, this would certainly be welcome functionality and should exist in a dedicated method. ds[key] is already very heavily overloaded in Xarray, so a more explicit option is nice to have, e.g., for the benefit of readability and static type checking. For the same reason, I would rather not put it inside isel() which already integer based indexing with a different call signature. My tentative suggestion is to call this new method sel_mask(), since that's what it does -- selection like sel/isel except based on a mask.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   N-dimensional boolean indexing  860418546
823674011 https://github.com/pydata/xarray/issues/5179#issuecomment-823674011 https://api.github.com/repos/pydata/xarray/issues/5179 MDEyOklzc3VlQ29tbWVudDgyMzY3NDAxMQ== shoyer 1217238 2021-04-20T23:51:46Z 2021-04-20T23:51:46Z MEMBER

I wonder if this is just a better proposal than making N-dimensional boolean indexing an alias for where: https://github.com/pydata/xarray/issues/1887#issuecomment-823673654

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   N-dimensional boolean indexing  860418546
821888349 https://github.com/pydata/xarray/issues/5179#issuecomment-821888349 https://api.github.com/repos/pydata/xarray/issues/5179 MDEyOklzc3VlQ29tbWVudDgyMTg4ODM0OQ== max-sixty 5635139 2021-04-17T21:12:11Z 2021-04-17T21:12:11Z MEMBER

Ah right, I see now, thanks for explaining.

Allowing pointwise indexing with bool indexes would also be welcome.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   N-dimensional boolean indexing  860418546
821870239 https://github.com/pydata/xarray/issues/5179#issuecomment-821870239 https://api.github.com/repos/pydata/xarray/issues/5179 MDEyOklzc3VlQ29tbWVudDgyMTg3MDIzOQ== max-sixty 5635139 2021-04-17T18:53:05Z 2021-04-17T18:53:05Z MEMBER

Thanks for the issue @Hoeze . Multi-dimensional bool indexing is definitely something we'd like to add.

How does your code differ from the proposals in https://github.com/pydata/xarray/issues/1887? In a brief look through the code — thanks for supplying it — I couldn't immediately see why we need a new dimension?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   N-dimensional boolean indexing  860418546

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);