issue_comments

Table actions

2 rows where author_association = "MEMBER" and issue = 803402841 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • check mypy at the end of some CI runs? · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
778085875 https://github.com/pydata/xarray/issues/4881#issuecomment-778085875 https://api.github.com/repos/pydata/xarray/issues/4881 MDEyOklzc3VlQ29tbWVudDc3ODA4NTg3NQ== mathause 10194086 2021-02-12T09:36:18Z 2021-02-12T09:36:18Z MEMBER

However, I don't think we should add mypy steps to our CI. Instead, I would prefer new jobs (not sure how many, though).

Works for me. I am also fine only testing in the ubuntu-latest py3.8 environment. I suggested ubuntu-latest py37-min-all-deps because we may now need to special-case depending on the numpy version.

https://github.com/pydata/xarray/blob/0b8ec0cfa41b0a0919a3754a8909d64a223de7e6/xarray/core/npcompat.py#L82-L85

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   check mypy at the end of some CI runs? 803402841
777873298 https://github.com/pydata/xarray/issues/4881#issuecomment-777873298 https://api.github.com/repos/pydata/xarray/issues/4881 MDEyOklzc3VlQ29tbWVudDc3Nzg3MzI5OA== keewis 14808389 2021-02-11T23:53:21Z 2021-02-11T23:53:21Z MEMBER

Therefore we missed the errors that pop up when running mypy with numpy 1.20 installed.

that's true, mypy won't be able to check for changes in the type hints of dependencies if it is run by pre-commit. However, I don't think we should add mypy steps to our CI. Instead, I would prefer new jobs (not sure how many, though).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   check mypy at the end of some CI runs? 803402841

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);