home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 777873298

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4881#issuecomment-777873298 https://api.github.com/repos/pydata/xarray/issues/4881 777873298 MDEyOklzc3VlQ29tbWVudDc3Nzg3MzI5OA== 14808389 2021-02-11T23:53:21Z 2021-02-11T23:53:21Z MEMBER

Therefore we missed the errors that pop up when running mypy with numpy 1.20 installed.

that's true, mypy won't be able to check for changes in the type hints of dependencies if it is run by pre-commit. However, I don't think we should add mypy steps to our CI. Instead, I would prefer new jobs (not sure how many, though).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  803402841
Powered by Datasette · Queries took 1.035ms · About: xarray-datasette