home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 803402841

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
803402841 MDU6SXNzdWU4MDM0MDI4NDE= 4881 check mypy at the end of some CI runs? 10194086 closed 0     2 2021-02-08T10:04:44Z 2021-02-22T16:33:50Z 2021-02-22T16:33:50Z MEMBER      

We currently run mypy in the pre-commit hooks CI. However, this is done in an environment where no dependencies are installed. Therefore we missed the errors that pop up when running mypy with numpy 1.20 installed. (Please correct my if I misunderstood this). Should we add a new step to our CI and run mypy?

I think we should at least add this to ubuntu-latest py3.8. For more complete checks we could also go for ubuntu-latest py37-min-all-deps and upstream-dev.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4881/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed 13221727 issue

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 2 rows from issue in issue_comments
Powered by Datasette · Queries took 1.162ms · About: xarray-datasette